[BUG] - Inconsistent mapping of .seq parameter in nii_hdr_ext - osp_generate_nii_hdr_ext - Alex Craven

[alexcraven]

Describe the bug

osp_generate_nii_hdr_ext maps in.seq to the ProtocolName attribute of the nifti header extension, while io_loadspec_niimrs attempts to read the SequenceName attribute into seq. Hence: the value for seq is not preserved using Osprey functions to load a nifti file which was originally created using Osprey functions.

To Reproduce

1. Create a nifti file with io_writenii_mrs, defining the seq attribute
2. Load that same nifti file with io_loadspec_niimrs
3. Be dismayed by the disappearance of the seq attribute.

Expected behavior
The mapping between header elements and internal structures should be consistent across save and load.
The shorter SequenceName attribute seems more appropriate given its usage within Osprey (eg, in basis set selection), so I suggest osp_generate_nii_hdr_ext should map in.seq to SequenceName.

Additional info
Note that io_loadspec_niimrs also uses the ProtocolName attribute to identify Philips HBCD data, so an eventual fix would need to take this into account (I don't have data to test this case, hence not submitting a patch this time). Probably it's sufficient to change this instance to SequenceName too, unless these data are generated by an external tool.