Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GenericAPIView type stub lacks get_queryset method #17

Open
sminnee opened this issue Feb 19, 2022 · 1 comment
Open

GenericAPIView type stub lacks get_queryset method #17

sminnee opened this issue Feb 19, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@sminnee
Copy link

sminnee commented Feb 19, 2022

I'm running djangorestframework 3.13.1 and djangorestframework-types 0.6.0

GenericAPIView defines a get_queryset(self) method.

The type stub does not.

It looks like djangorestframework-stubs package has added this - https://github.com/typeddjango/djangorestframework-stubs/blob/master/rest_framework-stubs/generics.pyi#L20 - is it worth pulling upstream changes into this package?
@sbdchd sbdchd added the bug Something isn't working label Feb 19, 2022
@knyghty knyghty mentioned this issue Aug 12, 2022
Merged
@dolfandringa
Copy link

This was resolved in version 0.7.1 by @knyghty (fancy seeing you here), but somehow a new 0.8.0 (see #31) seems to have been published since then that isn't in this repository that reverted that fix again

(screenshot from the downloaded version from pypi)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sminnee @dolfandringa @sbdchd