You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 2, 2022. It is now read-only.
I like this package in that it is not a complete application, but an extension to add to our own application.
I've got some comments to help improve (and I can provide some PR, if needed):
the documentation about authorization should provide with an example of middleware (I know, it's very basic, but it makes things more clear) (done in PR #1)
we should be able to use our own css, in replacement of the original one, not only in addition
helpers should be loaded with composer (defined in composer.json), not in the service provider
when testing, I've noticed a blog featured image is required. It should be optional (and maybe configurable). By the way, the error message should more explicit than "Please make sure the entered data is valid" (since the information are sent with the json response, I guess it's possible)
the documentation does not mention the publishable files (assets, config, views), I guess that it's because they are published when running the blogged:install command. I think it's a good thing to remind they are published and what it's possible to do when overriding them.
the image in the post form is, in my opinion, much to big
next level would be to add tags to posts
As I said, I can provide PRs, so I'm not just requesting some features: I'm posting this issue to discuss whether you want them added or not. The only feature I'm not sure I can work on is the error message in the Vue component, since I'm not familiar at all with Vue and JS in general (but I may learn).
PS: sorry for not using the issue template, I wanted to avoid opening many issues at once.
The text was updated successfully, but these errors were encountered:
Hi,
I like this package in that it is not a complete application, but an extension to add to our own application.
I've got some comments to help improve (and I can provide some PR, if needed):
the documentation about authorization should provide with an example of middleware (I know, it's very basic, but it makes things more clear)(done in PR #1)helpers should be loaded with composer (defined incomposer.json
), not in the service providerI think it's possible to use artisan ((done with Publish and automatically load articles and categories policies #8)vendor:publish
) to also publish policies files with something like:artisan vendor:publish --tag=blogged.policies
blogged:install
command. I think it's a good thing to remind they are published and what it's possible to do when overriding them.As I said, I can provide PRs, so I'm not just requesting some features: I'm posting this issue to discuss whether you want them added or not. The only feature I'm not sure I can work on is the error message in the Vue component, since I'm not familiar at all with Vue and JS in general (but I may learn).
PS: sorry for not using the issue template, I wanted to avoid opening many issues at once.
The text was updated successfully, but these errors were encountered: