Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme issues #94

Open
msoupcoff opened this issue Feb 23, 2022 · 2 comments
Open

Dark theme issues #94

msoupcoff opened this issue Feb 23, 2022 · 2 comments

Comments

@msoupcoff
Copy link

msoupcoff commented Feb 23, 2022

Certain colors look to be hardcoded and thus look out of place or fail color contrast test when switching to dark theme. Also reported in core jira project (https://sakaiproject.atlassian.net/browse/SAK-46981)

  1. On Attendance tab:
    AttendanceTab

  2. After selecting an item to take attendance:
    TakeAttendance

  3. After selecting an item to take attendance & selecting the Edit attendance item icon:
    TakeAttendanceEditItem

  4. After selecting an item to take attendance & selecting the Print icon:
    TakeAttendancePrint

  5. After selecting an item to take attendance & scroll over students (odd rows):
    TakeAttendanceRowScrollover

  6. After selecting an item to take attendance & selecting a student's name
    AttendanceSelectedStudent

  7. On Attendance By Student tab:
    AttendanceByStudent

  8. On Grading tab:
    AttendanceGrading

  9. On Settings tab:
    AttendanceSettings

@profmikegreene
Copy link

You can assign this to me if no one on your team isn't already working on it.

@davidpbauer
Copy link
Collaborator

We have made some fixes to the dark theme locally. I can see if Joe who made the changes can make a pull request. It would at least be a place to start if you have more pressing things.

jkozar2 added a commit to jkozar2/attendance that referenced this issue Feb 24, 2022
SAKAI-5974 Modify many points of styling for Dark theme
jkozar2 added a commit to jkozar2/attendance that referenced this issue Feb 24, 2022
SAKAI-5974 Add new theme-independent sort icons, add theme to datepicker
ottenhoff pushed a commit that referenced this issue Feb 25, 2022
* First commit of UD dark theme changes - issue #94
SAKAI-5974 Modify many points of styling for Dark theme

* Second commit of dark theme changes form UD - issue #94
SAKAI-5974 Add new theme-independent sort icons, add theme to datepicker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants