Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AbuseTypes CRUD #275

Open
maebeale opened this issue Oct 10, 2019 · 5 comments
Open

Add AbuseTypes CRUD #275

maebeale opened this issue Oct 10, 2019 · 5 comments

Comments

@maebeale
Copy link
Collaborator

  • We have the db, but need to add CRUD views so Admin user can add/edit/delete abuse_types

  • AbuseType policy should require a new Permission constant, called SYSTEM_SETUP, for all AbuseType actions, with the following exception:

  • AbuseTypesController needs to still service the json call (but change it to a different endpoint than the index, to help with the permission policy) from the /requesters/new form. This endpoint should not require ANY permissions, bc it'll get called from an unauthenticated user. So, it needs to get changed on the React side, added to the routes, and added to the AbuseTypesController.

@maebeale maebeale added help wanted Hacktoberfest Hacktoberfest issues for your resolution! labels Oct 10, 2019
@austenmadden
Copy link

We have the db, but need to add CRUD views so Admin user can add/edit/delete abuse_types

@maebeale any feelings about using https://github.com/thoughtbot/administrate for admin CRUD stuff? I've used it in the past and have really enjoyed how easy it made admin to setup.

@maebeale
Copy link
Collaborator Author

Hey there, @austenmadden ! Thanks for asking about this. We'd decided to roll our own CRUD for this project.

@maebeale
Copy link
Collaborator Author

@austenmadden would you like to be assigned to this issue?

@austenmadden
Copy link

@maebeale I had some free time this weekend but ended up working on other projects. If someone doesn't pick it up in the future maybe @eluthern and I will pair on it.

@maebeale
Copy link
Collaborator Author

Sounds great, @austenmadden ( and @eluthern )!

@maebeale maebeale added Priority: Low and removed Hacktoberfest Hacktoberfest issues for your resolution! labels Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants