Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when scanning a new barcode item, the item name doesn't correctly show up #4592

Open
3 tasks
cielf opened this issue Aug 11, 2024 · 0 comments
Open
3 tasks
Labels

Comments

@cielf
Copy link
Collaborator

cielf commented Aug 11, 2024

Details

Recreation note:

if you don't have a barcode scanner -- wherever we say "scanning", you can just type in the barcode and hit enter.

When scanning a new (previously unrecognized) barcode, the "new barcode" dialog correctly pops up, but after selecting quantity + item, only the quantity shows up as populated in the item entry, and it appears that no particular item has been selected yet.

Related, the text focus remains on the barcode entry that the user as just added rather than finalizing (via hitting enter) and proceeding to new item. It appears when I press Enter manually that the item name is correctly updated, Add Item is auto-pressed, and the text focus moves to the (as-yet empty) barcode entry text block for the new item.

That could mean that the only required fix is to ensure the 'Enter' action equivalent is still triggered when returning from adding the info for the new barcode item? (Usually the barcode scanner's 'Enter' causes the item name lookup to work AND jump to a new Add Item.)

Image

Image

Tested+verified in both Firefox and Chrome.

Why fix?

Reduce confusion and, in addition (with the missing Enter action), reduce likelihood that user accidentally keeps adding barcodes to the same field (which will keep looking like new barcodes to the app and keep causing the app to ask what the new entry is and keep suppressing the Enter action).

Criteria for completion

  • item name shows up consistently in the gui
  • text focus jumps to new Add Item after adding details for new barcode
  • tests to demonstrate that.

Questions for developers (i.e. Scott, who reported it)

TODO: add screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant