Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r-session-complete misinterprets text files as binary and cannot open preview in IDE #478

Open
kmasiello opened this issue Feb 16, 2023 · 3 comments
Labels
workbench Specific to workbench images

Comments

@kmasiello
Copy link

Workbench containers running purely from rstudio/r-session-complete are unable to open text files that don't have an extension, e.g., DESCRIPTION, NAMESPACE, and renv.lock in the RStudio IDE. Error message is pasted below:

"file is binary rather than text so cannot be opened by the source editor"
image

Confirmed that the utility file does not exist within the container. After sudo apt-get install file the files will open in the editor. The file utility should be added to r-session-complete so the IDE experience does not ship broken.

Confirmed this behavior in:
jammy-2022.12.0
bionic-2022.12.0
centos7-2022.12.0

@kmasiello
Copy link
Author

@colearendt I can make a PR if this sounds good to you.

@colearendt
Copy link
Contributor

colearendt commented Feb 16, 2023

Sounds great! Please do! May be worth adding a test as well
https://github.com/rstudio/rstudio-docker-products/blob/main/r-session-complete/test/goss.yaml

Would look like:

package:
  file:
    installed: true

Might want to do the same for Workbench too, just to be safe and make sure we never miss it. We should also probably pass this requirement upstream... if the product requires it to function, I suspect it should declare the dependency in its installer (or fail more gracefully)

@bschwedler
Copy link
Contributor

Related to #554

@colearendt colearendt added the workbench Specific to workbench images label Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workbench Specific to workbench images
Projects
None yet
Development

No branches or pull requests

3 participants