From 694320f3fc1468582325b7eef922b0b56b1bb0c4 Mon Sep 17 00:00:00 2001
From: richelbilderbeek <richel@richelbilderbeek.nl>
Date: Fri, 27 Oct 2023 11:54:41 +0200
Subject: [PATCH] Deprecate 'update_babette'

---
 NEWS.md                              | 18 +++++++++++++++++
 R/update_babette.R                   | 30 +++++++++++-----------------
 tests/testthat/test-update_babette.R |  4 +---
 3 files changed, 31 insertions(+), 21 deletions(-)

diff --git a/NEWS.md b/NEWS.md
index 7d0c701..4cdd2d9 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -2,6 +2,24 @@
 
 Newest versions at top.
 
+## babette v2.3.4 (unreleased)
+
+### NEW FEATURES
+
+  * None
+  
+### MINOR IMPROVEMENTS
+
+  * Deprecate 'upgrade_babette', as this is against CRAN guidelines
+
+### BUG FIXES
+
+  * None
+
+### DEPRECATED AND DEFUNCT
+
+  * None
+
 ## babette v2.3.3 (2022-09-25)
 
 ### NEW FEATURES
diff --git a/R/update_babette.R b/R/update_babette.R
index 2e6c1e5..dfef581 100644
--- a/R/update_babette.R
+++ b/R/update_babette.R
@@ -1,25 +1,19 @@
+#' Deprecated function.
+#'
 #' Update all babette dependencies, by installing their
-#' latest versions
+#' latest versions.
+#'
+#' See \url{https://github.com/richelbilderbeek/babetteinstall}
+#' how to do this.
 #' @inheritParams remotes::install_github
 #' @author Giovanni Laudanno, Richèl J.C. Bilderbeek
-#' @examples
-#' \dontrun{
-#'   # Updates the babette dependencies without asking
-#' }
-#' beastier::remove_beaustier_folders()
 #' @export
 update_babette <- function(upgrade = "default") {
-  repo_names <- c(
-    "ropensci/beautier", "ropensci/tracerer", "ropensci/beastier",
-    "ropensci/mauricer"
+  stop(
+    "'update_babette' is deprecated, ",
+    "as it did not follow CRAN guidelines. ",
+    "",
+    "Tip: one can use 'babetteinstall::updateba_bette' ",
+    "(from 'https://github.com/richelbilderbeek/babetteinstall')"
   )
-  for (repo_name in repo_names) {
-    remotes::install_github(
-      repo_name,
-      ref = "develop",
-      quiet = TRUE,
-      dependencies = TRUE,
-      upgrade = upgrade
-    )
-  }
 }
diff --git a/tests/testthat/test-update_babette.R b/tests/testthat/test-update_babette.R
index 40c7942..7c79fdb 100644
--- a/tests/testthat/test-update_babette.R
+++ b/tests/testthat/test-update_babette.R
@@ -1,5 +1,3 @@
 test_that("update in silence", {
-  if (!beautier::is_on_ci()) return()
-  update_babette()
-  expect_silent(update_babette())
+  expect_error(update_babette(), "deprecated")
 })