Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog generator seems to ignore changes between last patch & minor releases #7825

Open
Wumpf opened this issue Oct 18, 2024 · 1 comment · May be fixed by #7844
Open

Changelog generator seems to ignore changes between last patch & minor releases #7825

Wumpf opened this issue Oct 18, 2024 · 1 comment · May be fixed by #7844
Assignees
Labels
⛴ release Related to shipping or publishing

Comments

@Wumpf
Copy link
Member

Wumpf commented Oct 18, 2024

Need to dig deeper but we have at least a single example of this happening:
#7238 was not mentioned in the 0.19 release changelog. On the pr it says that it’s on 0.18.1/2. However, the PR landed on Aug 20, 0.18.1 was published on Aug 29 but 0.18.0 on Aug 16. But from the looks of it we did a proper branch of for 0.18.1 (and then pushed out 0.18.2 on the same, yanking 0.18.1 because we forgot something).

(this concrete one has been added manually to the changelog by now, but it should still possible to repro this!)

@Wumpf Wumpf added the ⛴ release Related to shipping or publishing label Oct 18, 2024
@Wumpf Wumpf added this to the Spring Cleaning milestone Oct 18, 2024
@emilk emilk self-assigned this Oct 21, 2024
@emilk
Copy link
Member

emilk commented Oct 21, 2024

This was user error - I did

scripts/generate_changelog.py --commit-range 0.18.2..HEAD

and should have done

scripts/generate_changelog.py --commit-range 0.18.0..HEAD

I'll see if I can make the same mistake impossible in the future.

@emilk emilk linked a pull request Oct 21, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛴ release Related to shipping or publishing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants