Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we be able to click the header text to collapse the header? #6418

Open
emilk opened this issue May 23, 2024 · 4 comments
Open

Should we be able to click the header text to collapse the header? #6418

emilk opened this issue May 23, 2024 · 4 comments
Labels
🪳 bug Something isn't working 🧑‍🎨 Design Requires UX/UI designer input ui concerns graphical user interface

Comments

@emilk
Copy link
Member

emilk commented May 23, 2024

Two problems
A) only the arrow is clickable
B) the arrow does not respond to hover

collapse-ui

Maybe A) is fine (it's consistent when clicking the title does something else), but B) is not.
Everything that is clickable should light up when hovered.

@emilk emilk added 🪳 bug Something isn't working ui concerns graphical user interface labels May 23, 2024
abey79 added a commit that referenced this issue May 24, 2024
### What

- Part of  #6418

Before:


![collapse-ui](https://github.com/rerun-io/rerun/assets/1148717/5bd9f55a-69a0-4d27-8393-26b8b376cf5d)

After:


![Export-1716534172555](https://github.com/rerun-io/rerun/assets/49431240/bc915eb9-9c45-4295-91f7-3ec889e957bc)


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6426?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6426?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6426)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
@emilk
Copy link
Member Author

emilk commented Aug 5, 2024

B) is fixed, but A) is still an issue

@emilk emilk changed the title Collapsing ListItem button feels dead Should we be able to click the header text to collapse the header? Aug 5, 2024
@emilk emilk added the 🧑‍🎨 Design Requires UX/UI designer input label Aug 5, 2024
@abey79
Copy link
Member

abey79 commented Aug 5, 2024

When the item is selectable (like in the blueprint tree), I think you dont want the "select" action (aka click) to trigger an unwanted change of collapsedness. This is the reason why clicking on the triangle specifically is required. We could make the entire item clickable to un/collapse when interactive(false) though, but it would be somewhat inconsistant.

@emilk
Copy link
Member Author

emilk commented Oct 21, 2024

@gavrelina what do you think about this?

@gavrelina
Copy link
Member

TLTR: Yes!

I think it's a very good practice to make the whole label actionable to whatever action it belongs to, as it improves the affordance (in the case of the issue: open/close through the label, other example: check box is ticked even if user clicks on the label). Good comment from Antoine that we have sometimes combinations of those. In that case we should respect the action that is "the most contextual to the label".

And the comment that it's not consistent —> I think that is not a problem, as it overall gives a better experience, and one may even say consistent in the context (even if not in implementation). Also! The section selections do close/open when one clicks on the label, so we will actually be more consistent! ;)

I could not quickly find an example of combination that Antoine is mentioning, let me know a concrete example if someone sees one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🧑‍🎨 Design Requires UX/UI designer input ui concerns graphical user interface
Projects
None yet
Development

No branches or pull requests

3 participants