Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't write tags to files with ORF and other extensions #267

Open
andrew-taylor opened this issue Oct 29, 2022 · 2 comments
Open

can't write tags to files with ORF and other extensions #267

andrew-taylor opened this issue Oct 29, 2022 · 2 comments
Labels
cli Command-line interface features and improvements

Comments

@andrew-taylor
Copy link

FYI files with ORF (and RAW and dmg I think) extensions aren't recognized as image files
but, unless I missing something, otherwise the functionality is actually present to write tags from the CLI
(maybe they can't be displayed by UI - I know there are a pile of RAW formats)
My use case is modifying/creating xmp files rather than modifying the image file anyway but something to consider.

$  naturtag -t 10277  a.ORF
Not a valid path: /tmp/a.ORF
$ ln -s a.ORF a.jpg
$ naturtag -t 10277  a.jpg
$ exiftool a.ORF |grep taxon
Subject                         : "Perching Birds", "Pheucticus Grosbeaks", "Yellow Grosbeak", Animalia, Animals, Birds, Chordates, taxonomy:kingdom=Animalia, taxonomy:phylum=Chordata, taxonomy:subphylum=Vertebrata, taxonomy:class=Aves, taxonomy:order=Passeriformes, taxonomy:family=Cardinalidae, taxonomy:genus=Pheucticus, "taxonomy:species=Pheucticus chrysopeplus", inat:taxon_id=10277, dwc:taxonID=10277
Subject Reference               : "Perching Birds", "Pheucticus Grosbeaks", "Yellow Grosbeak", Animalia, Animals, Birds, Chordates, taxonomy:kingdom=Animalia, taxonomy:phylum=Chordata, taxonomy:subphylum=Vertebrata, taxonomy:class=Aves, taxonomy:order=Passeriformes, taxonomy:family=Cardinalidae, taxonomy:genus=Pheucticus, "taxonomy:species=Pheucticus chrysopeplus", inat:taxon_id=10277, dwc:taxonID=10277
XP Subject                      : "Perching Birds","Pheucticus Grosbeaks","Yellow Grosbeak",Animalia,Animals,Birds,Chordates,taxonomy:kingdom=Animalia,taxonomy:phylum=Chordata,taxonomy:subphylum=Vertebrata,taxonomy:class=Aves,taxonomy:order=Passeriformes,taxonomy:family=Cardinalidae,taxonomy:genus=Pheucticus,"taxonomy:species=Pheucticus chrysopeplus",inat:taxon_id=10277,dwc:taxonID=10277
@JWCook JWCook added the cli Command-line interface features and improvements label Oct 30, 2022
@JWCook JWCook added this to the v0.8 milestone Oct 30, 2022
@JWCook
Copy link
Member

JWCook commented Oct 30, 2022

Sure, I can do that. I have a separate issue for adding raw file support to the UI, which will just take a little more work to display image previews: #232

The CLI will be easier. Instead of handling raw file extensions specifically (it's a fairly large pile!), I could:

  • Allow passing any file types to the CLI
  • If it's not a supported image type but has an xmp sidecar file, only write to the sidecar
  • Only raise an error if it's not a supported image type and doesn't have a sidecar
  • If a directory or glob pattern is given, match supported image types plus any extra xmp files

@JWCook
Copy link
Member

JWCook commented Oct 30, 2022

By the way, you're one of the first people besides myself to use this tool, so I appreciate the suggestions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Command-line interface features and improvements
Projects
None yet
Development

No branches or pull requests

2 participants