-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use native bindings #1
Comments
It would be great if we could merge our projects. I'm not familiar with node bindings. Is it possible to make the echoprint library optional during npm install? I think that would be necessary in order to make our projects compatible. Other than that, both seem to operate pretty similarly except for the way in which we pass parameters. The cli interface also does not require an index/offset and takes values in seconds rather than in samples. My thinking is that if we merge we can use the echoprint library if a buffer is passed in and the cli if it's a string/filepath. The numSamples/offset or songOffset/index can be interpreted accordingly. Is that a reasonable approach? On May 4, 2013, at 6:44 PM, Greg Thornton notifications@github.com wrote:
|
Well the echoprint-codgen package itself is MIT licensed, so we can just throw it in a |
Almost there. https://github.com/xdissent/node-echoprint-codegen/tree/hybrid It took a while to get node-gyp to do what I needed, but now I'm building both the lib and the binary from |
There ya go: https://github.com/xdissent/node-echoprint-codegen/tree/hybrid |
This is crazy, but I built the same thing yesterday: https://github.com/xdissent/node-echoprint-codegen
The cli wasn't working for me because I need to operate on raw pcm data from within node, so I wrote a C++ addon to interface with the codegen library directly. Can we merge our projects maybe?
The text was updated successfully, but these errors were encountered: