From b5d9409402e3f3858c5fca85ea21304f12dec384 Mon Sep 17 00:00:00 2001 From: Mohammed Abdi Date: Tue, 7 Nov 2023 10:39:09 -0500 Subject: [PATCH] nit for dashboard integration with odh proper Signed-off-by: Mohammed Abdi --- frontend/src/pages/MCADashboard/MCADTabs.tsx | 7 ++++--- frontend/src/pages/MCADashboard/Tables/quota-table.tsx | 2 +- frontend/src/utilities/NavData.tsx | 4 ++-- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/frontend/src/pages/MCADashboard/MCADTabs.tsx b/frontend/src/pages/MCADashboard/MCADTabs.tsx index cbd4afe46f..f9d7224c78 100644 --- a/frontend/src/pages/MCADashboard/MCADTabs.tsx +++ b/frontend/src/pages/MCADashboard/MCADTabs.tsx @@ -1,10 +1,11 @@ import React from 'react'; import { Tabs, Tab, TabTitleText, TabTitleIcon } from '@patternfly/react-core'; -import UsersIcon from '@patternfly/react-icons/dist/esm/icons/users-icon'; +//import UsersIcon from '@patternfly/react-icons/dist/esm/icons/users-icon'; // import BoxIcon from '@patternfly/react-icons/dist/esm/icons/box-icon'; import DatabaseIcon from '@patternfly/react-icons/dist/esm/icons/database-icon'; // import ServerIcon from '@patternfly/react-icons/dist/esm/icons/server-icon'; // import LaptopIcon from '@patternfly/react-icons/dist/esm/icons/laptop-icon'; +import DeezerIcon from '@patternfly/react-icons/dist/esm/icons/deezer-icon'; import ProjectDiagramIcon from '@patternfly/react-icons/dist/esm/icons/project-diagram-icon'; import { useWatchComponents } from '~/utilities/useWatchComponents'; import ApplicationsPage from '~/pages/ApplicationsPage'; @@ -54,9 +55,9 @@ export const MCADTabs: React.FunctionComponent = () => { title={ <> - + - Dashboard + Appwrapper Summary } aria-label="mcad-dashboard-tab" diff --git a/frontend/src/pages/MCADashboard/Tables/quota-table.tsx b/frontend/src/pages/MCADashboard/Tables/quota-table.tsx index c57888fb3b..cbeb685250 100644 --- a/frontend/src/pages/MCADashboard/Tables/quota-table.tsx +++ b/frontend/src/pages/MCADashboard/Tables/quota-table.tsx @@ -116,7 +116,7 @@ export const QuotaTable: React.FunctionComponent = ({ }, { field: 'numberofappwrappers', - label: '# of Appwrappers', + label: 'Appwrappers', sortable: true, }, { diff --git a/frontend/src/utilities/NavData.tsx b/frontend/src/utilities/NavData.tsx index 4cd87bdfb7..d7b738823a 100644 --- a/frontend/src/utilities/NavData.tsx +++ b/frontend/src/utilities/NavData.tsx @@ -132,14 +132,14 @@ export const getNavBarData = ( }); } } + // MCAD dashboard + navItems.push({ id: 'mcad', label: 'MCAD Dashboard', href: '/mcad' }); if (featureFlagEnabled(dashboardConfig.spec.dashboardConfig.disableModelServing)) { navItems.push({ id: 'modelServing', label: 'Model Serving', href: '/modelServing' }); } navItems.push({ id: 'resources', label: 'Resources', href: '/resources' }); - - navItems.push({ id: 'mcad', label: 'MCAD Dashboard', href: '/mcad' }); // path created for MCAD dashboard const settingsNav = getSettingsNav(isAdmin, dashboardConfig); if (settingsNav) {