From fcebba06ef034ff6c77a15ad8dffdf13238ca561 Mon Sep 17 00:00:00 2001 From: Philip Claesson Date: Thu, 10 Aug 2023 14:34:11 +0200 Subject: [PATCH] fix unlogical setting of OPAL_DATA_UPDATER_ENABLED In my latest pr #51, I introduced functionality that would avoid setting the OPAL_DATA_UPDATER_ENABLED variable on the client if the variable was set on the server. This is obviously a bit confusing. We should instead override the client env var on the client itself. --- templates/deployment-client.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/deployment-client.yaml b/templates/deployment-client.yaml index 5e1167d..da0a329 100644 --- a/templates/deployment-client.yaml +++ b/templates/deployment-client.yaml @@ -45,7 +45,7 @@ spec: {{- if .Values.server }} - name: OPAL_SERVER_URL value: {{ printf "http://%s:%v" (include "opal.serverName" .) .Values.server.port | quote }} - {{- if not (or (.Values.server.dataConfigSources.external_source_url) (.Values.server.dataConfigSources.config) (hasKey .Values.server.extraEnv "OPAL_DATA_UPDATER_ENABLED") ) }} + {{- if not (or (.Values.server.dataConfigSources.external_source_url) (.Values.server.dataConfigSources.config) (hasKey .Values.client.extraEnv "OPAL_DATA_UPDATER_ENABLED") ) }} - name: OPAL_DATA_UPDATER_ENABLED value: "False" {{- end }}