Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - DualListSelector next - isTree variant moves all items even with applied filter #10862

Open
adamviktora opened this issue Aug 15, 2024 · 3 comments · May be fixed by #11097
Open

Bug - DualListSelector next - isTree variant moves all items even with applied filter #10862

adamviktora opened this issue Aug 15, 2024 · 3 comments · May be fixed by #11097
Assignees
Labels

Comments

@adamviktora
Copy link
Contributor

adamviktora commented Aug 15, 2024

Describe the problem
DualListSelector next (new version in V6) - when isTree prop is true and we apply a search filter to only show few items, then click the "add all" button, it moves all items, including those which are not shown because of the filter.
This is an issue only with the isTree variant.

How do you reproduce the problem?

  1. open this example https://staging-v6.patternfly.org/components/dual-list-selector#with-tree
  2. type in "Fruits" to the left search bar
  3. click the "Add all" button (>>) to move the items to the right - all items will be moved, including Bread and Vegetables, which were invisible due to the filter.

Expected behavior
Only Fruits is moved, Bread and Vegetable will stay on the left side - it will not be shown because of the filter, but once the filter is removed, it shows in the list again.
It should behave like this example: https://staging-v6.patternfly.org/components/dual-list-selector/#using-more-complex-options-with-actions

Screenshots

Screen.Recording.2024-08-15.at.9.49.39.mov

What is your environment?

  • OS: macOS 14.6.1
  • Browser: Firefox
  • Version 128.0.3
@tlabaj
Copy link
Contributor

tlabaj commented Sep 5, 2024

We should be fixed in PF5 path release and also in v6

@tlabaj
Copy link
Contributor

tlabaj commented Sep 19, 2024

WE need to look into this. If this is a componet issue we may need to fix it in PF5. If it is example code we can just fix it in v6.

@adamviktora adamviktora self-assigned this Sep 30, 2024
@adamviktora
Copy link
Contributor Author

It is just in the example code. I am working on a fix now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: PR Review
2 participants