-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS mojave support #82
Comments
@mateor you were able to do this last time, feel like taking it on again? Also, is this possible to do in some scratch mac on https://www.macstadium.com/ ? Happy to do it if so and you remind me how... |
@michaelgmiller are you able to work around this with
or for now? |
Yup, I've been using that as a workaround in the mean time! |
See pantsbuild/pants#6591 for a more permanent fix that should cover future mac upgrades (at least until Macs change their hardware arch, or there's some other breaking change...) |
Hi all. Sorry I missed this ping. I only saw it now when I realized that watchman wasn't updated. Rebuilding the binaries properly requires wide triaging of Make files for bitrot across a variety of ecosystems, and was a real pain when I did it for 10.12. I think that Benjy's patch is a big win overall. John took the shortest path for 10.13 and generously documented his approach in the commit: $ find $PWD/build-support/bin -wholename "*/mac/10.12/*" -type f | {
while read binary
do
newbin=${binary/\/10.12\//\/10.13\/}
binary=$(basename ${newbin})
newdir=$(dirname ${newbin})
version=$(basename ${newdir})
rm -rf ${newdir}
mkdir -p ${newdir}
cd ${newdir}
ln -s ../../10.12/${version}/${binary}
done
} My org has been using the remapping trick via environmental variable, so AFIACT the compatibility guarantees have held.
I can't break away to do a full rebuild but given that our upstream solution of resuse is live in newer Pants distributions, how about I run that snippet and update this codebase with 10.14 symlinks for anyone using a Pants version that predates your patch? |
Similar to #17, pants needs binaries for macOS mojave
Exception message: Update --binaries-path-by-id to find binaries for (u'darwin', u'18')
The text was updated successfully, but these errors were encountered: