Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faint unexpected rectangle in the course about page #81

Closed
mariajgrimaldi opened this issue May 21, 2024 · 7 comments
Closed

Faint unexpected rectangle in the course about page #81

mariajgrimaldi opened this issue May 21, 2024 · 7 comments

Comments

@mariajgrimaldi
Copy link

Expected behavior

Not 100% sure - this might actually be a design choice rather than a bug.

Actual behavior

There's a light-colored rounded rectangle behind and offset from the course image. I'm not 100% sure that's intentional - not sure whether it's supposed to be there or directly behind the image.

Screenshot 2024-05-17 at 9 47 22 AM

Steps to reproduce

Just visit any About page.

Additional information

In ones without an image you get a blank square in front of the rectangle.

Screenshot 2024-05-17 at 9 48 06 AM

Original issue: openedx/wg-build-test-release#345

I'm opening this issue to confirm whether this is a design choice or a bug. I'm unfamiliar with the indigo theme, so I can't say for sure.

@mariajgrimaldi
Copy link
Author

label: release testing

@mariajgrimaldi
Copy link
Author

Well, that didn't work 😅.

@DawoudSheraz
Copy link

@hinakhadim FYI

@DawoudSheraz
Copy link

DawoudSheraz commented May 22, 2024

Well, that didn't work 😅.

I think this is because the repo is in overhangio organization and not Open edX.

@hinakhadim
Copy link
Collaborator

Hi @mariajgrimaldi ,

This is a design choice. The rectangle position is also correct and it won't be just behind the image.

However, the second screenshot is a bug. There should be the thumbnail/fallback course image in case of no course image.

@mariajgrimaldi
Copy link
Author

@hinakhadim: thanks for clarifying!

@hinakhadim
Copy link
Collaborator

This PR will resolve the second screenshot (bug).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants