Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for RFC 0794 DID Rotate #753

Open
swcurran opened this issue Dec 12, 2023 · 2 comments
Open

Add tests for RFC 0794 DID Rotate #753

swcurran opened this issue Dec 12, 2023 · 2 comments
Assignees

Comments

@swcurran
Copy link
Contributor

Various Aries Frameworks are adding support for [RFC 0794 DID Rotate]. Please add some tests for DID Rotate.

The tests should at minimum:

  • Establish a connection between test agents (say, Acme and Bob).
  • Have one of the agent (say, Acme) initiate a DID Rotate.
  • Execute another protocol, such as a trust ping, to ensure that the agents can still communicate.
@swcurran
Copy link
Contributor Author

This work is still early, as (AFAIK) none of the Aries Frameworks yet support this RFC, however, it is coming Real Soon Now. Once we have it supported in one, we'd like to be able to run AATH tests of the feature.

@TelegramSam @dbluhm -- anything to add to this?

@nodlesh
Copy link
Contributor

nodlesh commented Dec 15, 2023

Reading through the unqualified DID transition document it appears that as of Step 2, frameworks will no longer send an unqualified DID. If I understand correctly, Establish a connection between test agents (say, Acme and Bob) should be done with an unqualified DID. However at the point of Step 2, that won't be possible. The test agents when stood up don't come with any historical data, so if this is to be done, the scenario might have to look like this.

  • Start agent(s) at a version that supports sending unqualified DIDs.
  • Establish a connection between test agents (say, Acme and Bob).
  • Shutdown, upgrade to the version that no longer sends unqualified DIDs, then restart the agent(s)
  • Have one of the agent (say, Acme) initiate a DID Rotate.
  • Execute another protocol, such as a trust ping, to ensure that the agents can still communicate.

This agent upgrade process may be difficult to achieve in the test scenario. I'm wondering if the Transition RFC can loosen the requirement of not sending an unqualified DID in step 2 and higher? Maybe maintain a backdoor or a flag to tell the agent to send unqualified DIDs just for testing?

This suite of tests seems to have a limited lifespan. Once the frameworks fully move to qualified DIDs and all existing DIDs are rotated, then this suite can be retired. Maybe at that time, the frameworks can remove the ability to send unqualified DIDs through the testing backdoor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants