From a0709343236a509b0f6b71a834d419c8dd6b7280 Mon Sep 17 00:00:00 2001
From: Nathan Weinberg <nweinber@redhat.com>
Date: Wed, 20 Mar 2024 10:49:48 -0400
Subject: [PATCH] Add in final comparison stats with 'zero' values

---
 ...netobserv_touchstone_tolerancy_config.json | 66 +++++++++++++++++++
 .../netobserv_touchstone_tolerancy_rules.yaml | 16 ++++-
 2 files changed, 80 insertions(+), 2 deletions(-)

diff --git a/scripts/queries/netobserv_touchstone_tolerancy_config.json b/scripts/queries/netobserv_touchstone_tolerancy_config.json
index d25e85be..35d93f48 100644
--- a/scripts/queries/netobserv_touchstone_tolerancy_config.json
+++ b/scripts/queries/netobserv_touchstone_tolerancy_config.json
@@ -137,6 +137,39 @@
                     ]
                 }
             },
+            {
+                "filter": {
+                    "metric_name.keyword": "nFlowsErroredTotals"
+                },
+                "buckets": [
+                    "metric_name.keyword"
+                ],
+                "aggregations": {
+                    "value": [
+                        "max"
+                    ]
+                }
+            },
+            {
+                "filter": {
+                    "metric_name.keyword": "nFlowsErroredPerMinuteTotals"
+                },
+                "buckets": [
+                    "metric_name.keyword"
+                ],
+                "aggregations": {
+                    "value": [
+                        {
+                            "percentiles": {
+                                "percents": [
+                                    90
+                                ]
+                            }
+                        },
+                        "avg"
+                    ]
+                }
+            },
             {
                 "filter": {
                     "metric_name.keyword": "lokiRecordsWritten"
@@ -170,6 +203,39 @@
                     ]
                 }
             },
+            {
+                "filter": {
+                    "metric_name.keyword": "lokiRecordsDropped"
+                },
+                "buckets": [
+                    "metric_name.keyword"
+                ],
+                "aggregations": {
+                    "value": [
+                        "max"
+                    ]
+                }
+            },
+            {
+                "filter": {
+                    "metric_name.keyword": "lokiRecordsDroppedPerMinute"
+                },
+                "buckets": [
+                    "metric_name.keyword"
+                ],
+                "aggregations": {
+                    "value": [
+                        {
+                            "percentiles": {
+                                "percents": [
+                                    90
+                                ]
+                            }
+                        },
+                        "avg"
+                    ]
+                }
+            },
             {
                 "filter": {
                     "metric_name.keyword": "cpuFLPTotals"
diff --git a/scripts/queries/netobserv_touchstone_tolerancy_rules.yaml b/scripts/queries/netobserv_touchstone_tolerancy_rules.yaml
index fb140140..5ee14b4b 100644
--- a/scripts/queries/netobserv_touchstone_tolerancy_rules.yaml
+++ b/scripts/queries/netobserv_touchstone_tolerancy_rules.yaml
@@ -5,11 +5,23 @@
 - json_path: ["metric_name", "nFlowsProcessedPerMinuteTotals", "metric_name", "*", "avg(value)"]
   tolerancy: -10
   max_failures: 0
+- json_path: ["metric_name", "nFlowsErroredTotals", "metric_name", "*", "max(value)"]
+  tolerancy: -1
+  max_failures: 0
+- json_path: ["metric_name", "nFlowsErroredPerMinuteTotals", "metric_name", "*", "avg(value)"]
+  tolerancy: -1
+  max_failures: 0
 - json_path: ["metric_name", "lokiRecordsWritten", "metric_name", "*", "max(value)"]
-  tolerancy: 2
+  tolerancy: -10
   max_failures: 0
 - json_path: ["metric_name", "lokiRecordsWrittenPerMinute", "metric_name", "*", "avg(value)"]
-  tolerancy: 2
+  tolerancy: -10
+  max_failures: 0
+- json_path: ["metric_name", "lokiRecordsDropped", "metric_name", "*", "max(value)"]
+  tolerancy: -1
+  max_failures: 0
+- json_path: ["metric_name", "lokiRecordsDroppedPerMinute", "metric_name", "*", "avg(value)"]
+  tolerancy: -1
   max_failures: 0
 # CPU totals
 - json_path: ["metric_name", "cpuFLPTotals", "metric_name", "*", "avg(value)"]