Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persian language #1020

Merged
merged 11 commits into from
Aug 30, 2023
Merged

Persian language #1020

merged 11 commits into from
Aug 30, 2023

Conversation

CodeWithEmad
Copy link
Member

This will add Persian (fa_IR) language to the Authn MFE.
Additionally, the translations for other languages have been updated, and a few typos have been corrected.

@CodeWithEmad CodeWithEmad requested a review from a team as a code owner August 7, 2023 12:25
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 7, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Aug 7, 2023 •
edited
Loading

Thanks for the pull request, @CodeWithEmad! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Aug 7, 2023
@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Aug 15, 2023
@mphilbrick211
Copy link

Hi @CodeWithEmad! Just flagging that there are a couple failing checks. Thanks!

@CodeWithEmad
Copy link
Member Author

Hi @mphilbrick211
Thank you for letting me know. The issue has been resolved.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Aug 18, 2023
@e0d
Copy link
Contributor

e0d commented Aug 23, 2023

@CodeWithEmad looks like there are some CI failures, can you have a look?

@e0d e0d added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Aug 23, 2023
@mphilbrick211 mphilbrick211 added needs test run Author's first PR to this repository, awaiting test authorization from Axim and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Aug 24, 2023
@CodeWithEmad
Copy link
Member Author

consider it done @e0d!

@codecov
Copy link

codecov bot commented Aug 27, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c5caaeb) 84.52% compared to head (e5de7b2) 84.52%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1020   +/-   ##
=======================================
  Coverage   84.52%   84.52%           
=======================================
  Files         113      113           
  Lines        2190     2190           
  Branches      633      633           
=======================================
  Hits         1851     1851           
  Misses        323      323           
  Partials       16       16
Files Changed Coverage Δ
src/register/RegistrationPage.jsx 96.01% <ø> (ø)
src/recommendations/data/utils.js 87.09% <100.00%> (ø)
src/register/data/actions.js 100.00% <100.00%> (ø)
src/register/data/reducers.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zainab-amir
zainab-amir reviewed Aug 28, 2023
View reviewed changes
package-lock.json Outdated
Comment on lines 22170 to 22172
"version": "1.2.5",
"resolved": "https://registry.npmjs.org/word-wrap/-/word-wrap-1.2.5.tgz",
"integrity": "sha512-BN22B5eaMMI9UMtjrGd5g5eCYPpCPDUy0FJXbYsaT5zYxjFOckS53SQDE3pWkVoWpHXVb3BrYcEN4Twa55B5cA==",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it wasn't. I can remove the commit if it's not acceptable :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, please.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Aug 28, 2023
@mphilbrick211
Copy link

Hi @zainab-amir! When you get a moment, would you be able to approve the tests to run on this PR? They bounced back to needing approval.

@mphilbrick211 mphilbrick211 added needs test run Author's first PR to this repository, awaiting test authorization from Axim and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Aug 29, 2023
@zainab-amir zainab-amir merged commit daa7ae4 into openedx:master Aug 30, 2023
5 checks passed
@openedx-webhooks
Copy link

@CodeWithEmad 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

snglth pushed a commit to Abstract-Tech/community-theme-authn that referenced this pull request Jan 9, 2024
@CodeWithEmad @zainab-amir @snglth
feat: Add persian language (openedx#1020)
43b096e 

Co-authored-by: Zainab Amir <zainab.amir@arbisoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zainab-amir zainab-amir zainab-amir approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CodeWithEmad @openedx-webhooks @mphilbrick211 @e0d @zainab-amir