Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug ?] coordinate points json schema discrepency? #150

Open
xgui3783 opened this issue Nov 25, 2021 · 4 comments
Open

[bug ?] coordinate points json schema discrepency? #150

xgui3783 opened this issue Nov 25, 2021 · 4 comments
Assignees
Labels
BLOCKER no new release until this is fixed bug something isn't working

Comments

@xgui3783
Copy link
Collaborator

per https://github.com/HumanBrainProject/openMINDS_SANDS/blob/3602c70/schemas/miscellaneous/coordinatePoint.schema.tpl.json#L8-L16 and https://humanbrainproject.github.io/openMINDS/v3/SANDS/v3/miscellaneous/coordinatePoint.html , it seems CoordinatePoint > coordinates should be of type array, with at least 2, at most 3 items, of type qualitativeValue.

But the generated json schema seems to suggest that it is a single object of type qualitativeValue ?

@xgui3783
Copy link
Collaborator Author

perhaps related, openMINDS/v3/SANDS/v3/atlas/commonCoordinateSpace.schema.json > properties > https://openminds.ebrains.eu/vocab/axesOrigin > properties > typeOfUncertainty has no type. The object simple reads:

{
    "typeOfUncertainty": {
        "_instruction": "Add the type of uncertainty used for this quantitative value.",
        "_linkedTypes": [
            "https://openminds.ebrains.eu/controlledTerms/TypeOfUncertainty"
        ],
        "description": "Distinct technique used to quantify the uncertainty of a measurement.",
        "title": "typeOfUncertainty"
    }
}

@xgui3783
Copy link
Collaborator Author

Re second issue (quoted below), I seem to have gleamed some additional information.

It appears the _linkedTypes infer the type?

If that is the case, shouldn't the openminds generator actually populate the schema? Yes it will signficantly increase the size of the json schema, but it is not designed to be human readable any way? in the html generated, it can still rely on the _linkedTypes to create the necessary hyper links?

perhaps related, openMINDS/v3/SANDS/v3/atlas/commonCoordinateSpace.schema.json > properties > https://openminds.ebrains.eu/vocab/axesOrigin > properties > typeOfUncertainty has no type. The object simple reads:

{
    "typeOfUncertainty": {
        "_instruction": "Add the type of uncertainty used for this quantitative value.",
        "_linkedTypes": [
            "https://openminds.ebrains.eu/controlledTerms/TypeOfUncertainty"
        ],
        "description": "Distinct technique used to quantify the uncertainty of a measurement.",
        "title": "typeOfUncertainty"
    }
}

xgui3783 added a commit to FZJ-INM1-BDA/siibra-python that referenced this issue Nov 26, 2021
@lzehl
Copy link
Member

lzehl commented Jan 4, 2022

@xgui3783 thanks for this issue.

For the "_linkedTypes": they indeed infer the type information within the openMINDS syntax. Within JSON-Schema this is resolved in referencing the respective schema type (not including it as a nested schema as it is done for "_embeddedTypes"). @olinux I just realized that we do not make use of "@ref" for linked types in the JSON-Schemas. What was the reason for this decision?

For the CoordinatePoint > coordinates issue: this seems to be indeed an error in the building pipeline: @olinux can you have a look at this?

@lzehl
Copy link
Member

lzehl commented Mar 30, 2022

@olinux did you have a look yet?

@lzehl lzehl added the bug something isn't working label Jan 19, 2023
@lzehl lzehl added the BLOCKER no new release until this is fixed label Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLOCKER no new release until this is fixed bug something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants