Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed rmTypeName from RM and Java #7

Open
ppazos opened this issue Sep 3, 2013 · 5 comments
Open

Mixed rmTypeName from RM and Java #7

ppazos opened this issue Sep 3, 2013 · 5 comments

Comments

@ppazos
Copy link
Contributor

ppazos commented Sep 3, 2013

Some CObjects have rmTypeName equals as the specification, and some others have the Java class names, e.g. DvQuantity (Java) instead of DV_QUANTITY (specs).

I believe all rmTypeNames should be as the specs. Is that a bug or is on purpose?

@rongchen
Copy link
Contributor

rongchen commented Sep 3, 2013

That's a bug. Thanks, Pablo!
/Rong

On 3 September 2013 04:18, Pablo Pazos notifications@github.com wrote:

Some CObjects have rmTypeName equals as the specification, and some others
have the Java class names, e.g. DvQuantity (Java) instead of DV_QUANTITY
(specs).

I believe all rmTypeNames should be as the specs. Is that a bug or is on
purpose?


Reply to this email directly or view it on GitHubhttps://github.com//issues/7
.

@ppazos
Copy link
Contributor Author

ppazos commented Dec 9, 2013

Thanks Rong, I'm on this issue.

List of problematic types:

  • CODE_PHRASE > CodePhrase
  • DV_QUANTITY > DvQuantity
  • DV_DURATION > DvDuration
  • DV_ORDINAL > DvOrdinal

BTW, is ok for a CPrimitiveObject to have rmTypeName == "Boolean" when the CPO is contained in a CComplexObject with rmTypeName == "DV_BOOLEAN"?

@ppazos
Copy link
Contributor Author

ppazos commented Dec 9, 2013

I have questions about types mentioned on RMInspector.java and RMObjectBuilder.

Should these be RM type names or Java class names?

private static final String[] SKIPPED_TYPES_IN_MATCHING = { "DvDateTime",
"DvDate", "DvTime", "DvDuration", "Cluster",
// due to clash with DvText
"TerminologyID", "ArchetypeID", "TemplateID", "ISO_OID",
"HierObjectID", "DvBoolean", "InternetID", "UUID",
"ObjectVersionID"
};

ppazos added a commit to ppazos/java-libs that referenced this issue Dec 10, 2013
icorbal added a commit that referenced this issue Dec 10, 2013
fix to issue #7
Thanks Pablo!
@icorbal
Copy link
Contributor

icorbal commented Dec 10, 2013

Thanks for the fix! :-)

@ppazos
Copy link
Contributor Author

ppazos commented Dec 21, 2013

Thank you Iago. There are some questions pending in my previous messages, if Rong is around I would like his input to be sure the solution to this issue is ok, or maybe I have to change something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants