Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the --directory option #293

Closed
deemp opened this issue Jun 5, 2024 · 13 comments
Closed

Support the --directory option #293

deemp opened this issue Jun 5, 2024 · 13 comments

Comments

@deemp
Copy link
Member

deemp commented Jun 5, 2024

@maxonfjvipon

Problem

Currently, it's unclear where eoc looks for files when executing the commands phi, test, unphi, print.

Solution

  1. For these commands, add the --directory option that accepts a path to a directory.
  2. Make eoc look for files only in the specified directory.
  3. By default (when the --directory option is not provided), eoc must look for files in the current directory.
  4. The default --directory option value must be documented in the CLI.
  5. eoc must report a human-readable error when it found no matching files.
  6. eoc should never recurse into a .eoc directory unless this directory is explicitly specified via --directory .eoc.
@deemp deemp changed the title Support --directory option Support the --directory option Jun 5, 2024
maxonfjvipon added a commit to maxonfjvipon/eoc that referenced this issue Jun 5, 2024
@deemp
Copy link
Member Author

deemp commented Jun 5, 2024

@maxonfjvipon, please document somewhere how to convert PHI to EO and EO to PHI with this option.

@maxonfjvipon
Copy link
Member

maxonfjvipon commented Jun 5, 2024

@deemp you can use eoc phi --help to get info about a command and flags. The same story with unphi and print

maxonfjvipon added a commit to maxonfjvipon/eoc that referenced this issue Jun 5, 2024
@deemp
Copy link
Member Author

deemp commented Jun 5, 2024

@maxonfjvipon, there's no info on where it prints the files

Usage: eoc print [options]

Generate EO files from XMIR files

Options:
  -?, --help  Print this help information

@maxonfjvipon
Copy link
Member

maxonfjvipon commented Jun 5, 2024

@deemp it'll be added here for phi, unphi and print commands

maxonfjvipon added a commit to maxonfjvipon/eoc that referenced this issue Jun 5, 2024
yegor256 added a commit that referenced this issue Jun 5, 2024
fix(#293): added directories options for `phi` and `unphi`
@maxonfjvipon
Copy link
Member

@yegor256 let's make a new release with tag 0.21.0

@yegor256
Copy link
Member

yegor256 commented Jun 5, 2024

@rultor release, tag is 0.21.0

@yegor256
Copy link
Member

yegor256 commented Jun 5, 2024

@rultor status

1 similar comment
@yegor256
Copy link
Member

yegor256 commented Jun 5, 2024

@rultor status

@rultor
Copy link
Contributor

rultor commented Jun 5, 2024

@rultor release, tag is 0.21.0

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Contributor

rultor commented Jun 5, 2024

@rultor status

@yegor256 This is what's going on here:

  • request 2149836918 is in processing, command is release
  • request has 3 parameter(s):
  • head: git@github.com:objectionary/eoc.git
  • head_branch: master
  • tag: 0.21.0
  • build is not running

More information about Rultor commands you can get here.

1 similar comment
@rultor
Copy link
Contributor

rultor commented Jun 5, 2024

@rultor status

@yegor256 This is what's going on here:

  • request 2149836918 is in processing, command is release
  • request has 3 parameter(s):
  • head: git@github.com:objectionary/eoc.git
  • head_branch: master
  • tag: 0.21.0
  • build is not running

More information about Rultor commands you can get here.

@objectionary objectionary deleted a comment from rultor Jun 5, 2024
@objectionary objectionary deleted a comment from rultor Jun 5, 2024
@objectionary objectionary deleted a comment from rultor Jun 5, 2024
@objectionary objectionary deleted a comment from rultor Jun 5, 2024
@objectionary objectionary deleted a comment from rultor Jun 5, 2024
@objectionary objectionary deleted a comment from rultor Jun 5, 2024
@rultor
Copy link
Contributor

rultor commented Jun 5, 2024

@rultor release, tag is 0.21.0

@yegor256 Done! FYI, the full log is here (took me 30min)

@objectionary objectionary deleted a comment from rultor Jun 5, 2024
@objectionary objectionary deleted a comment from rultor Jun 5, 2024
@objectionary objectionary deleted a comment from rultor Jun 5, 2024
@objectionary objectionary deleted a comment from maxonfjvipon Jun 5, 2024
@objectionary objectionary deleted a comment from rultor Jun 5, 2024
@objectionary objectionary deleted a comment from rultor Jun 5, 2024
@objectionary objectionary deleted a comment from rultor Jun 5, 2024
maxonfjvipon added a commit to maxonfjvipon/eoc that referenced this issue Jun 6, 2024
maxonfjvipon added a commit to maxonfjvipon/eoc that referenced this issue Jun 6, 2024
maxonfjvipon added a commit to maxonfjvipon/eoc that referenced this issue Jun 6, 2024
@yegor256
Copy link
Member

@deemp I believe, it's fixed. If a similar issue shows up, please open a new ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants