From 6c282e5373db3c10171636c7a7c2f76902bd3132 Mon Sep 17 00:00:00 2001 From: Andrei Shapiro Date: Wed, 3 May 2023 21:48:49 +0000 Subject: [PATCH 1/2] chore: apply PSR-12 --- actions/class.ItemExport.php | 7 +++-- actions/class.ItemRunner.php | 12 +++---- actions/class.Main.php | 2 +- actions/class.RestFormItem.php | 2 +- actions/class.RestItems.php | 3 +- actions/class.SaSItems.php | 1 - actions/form/class.Item.php | 6 ++-- actions/form/class.RestItemForm.php | 4 +-- helpers/class.Deployment.php | 18 +++++------ helpers/class.Xhtml.php | 31 ++++++++++--------- helpers/class.Xslt.php | 7 +++-- includes/constants.php | 2 +- includes/raw_start.php | 2 ++ .../Version202012161236262141_taoItems.php | 1 - models/classes/CategoryService.php | 6 ++-- .../classes/Import/class.ExtractException.php | 2 +- .../classes/Import/class.ImportException.php | 2 +- .../classes/Import/class.ParsingException.php | 2 +- models/classes/ItemCompilerIndex.php | 1 - models/classes/ItemModelStatus.php | 10 +++--- .../classes/PreviewClientConfigRegistry.php | 3 +- models/classes/asset/Loader.php | 9 +++--- .../class.CompilationFailedException.php | 2 +- models/classes/class.CrudItemsService.php | 12 +++---- models/classes/class.ItemCompiler.php | 17 +++++----- models/classes/class.ItemExporter.php | 23 ++++++-------- models/classes/class.ItemModelException.php | 2 +- models/classes/class.TemplateRenderer.php | 27 ++++++++-------- .../classes/event/ItemContentClonedEvent.php | 1 - models/classes/event/ItemCreatedEvent.php | 1 - models/classes/event/ItemDuplicatedEvent.php | 1 - models/classes/event/ItemExportEvent.php | 1 - models/classes/event/ItemImportEvent.php | 1 - models/classes/event/ItemRdfUpdatedEvent.php | 1 - models/classes/event/ItemRemovedEvent.php | 1 - models/classes/event/ItemUpdatedEvent.php | 5 ++- .../exporter/class.DefaultItemExporter.php | 2 +- .../classes/interface.ExportableItemModel.php | 2 +- .../classes/interface.ImportableItemModel.php | 1 + models/classes/interface.itemModel.php | 7 +++-- models/classes/media/ItemMediaResolver.php | 1 - models/classes/media/LocalItemSource.php | 7 ++--- models/classes/ontology/ItemAuthorRole.php | 2 +- models/classes/pack/ExceptionMissingAsset.php | 1 - .../classes/pack/ExceptionMissingEncoder.php | 1 - models/classes/pack/ItemPacker.php | 5 ++- models/classes/pack/Packer.php | 10 +++--- .../pack/encoders/Base64fileEncoder.php | 2 +- .../classes/preview/ItemPreviewerService.php | 2 +- .../preview/OntologyItemNotFoundException.php | 1 - .../classes/render/ItemAssetsReplacement.php | 3 +- models/classes/render/NoneItemReplacement.php | 2 -- .../search/class.XmlItemContentTokenizer.php | 8 ++--- scripts/update/class.Updater.php | 3 +- test/integration/XhtmlTest.php | 11 +++---- test/integration/pack/PackerTest.php | 3 +- test/integration/taoApiServer.php | 2 +- test/unit/XmlItemContentTokenizerTest.php | 4 +-- test/unit/models/classes/ItemsServiceTest.php | 2 +- test/unit/pack/ItemPackTest.php | 4 +-- test/unit/pack/encoder/Base64EncoderTest.php | 1 + .../pack/encoder/Base64fileEncoderTest.php | 1 + test/unit/pack/encoder/NoneEncoderTest.php | 2 +- .../unit/preview/ItemPreviewerServiceTest.php | 1 - test/unit/render/NoneItemReplacementTest.php | 1 - 65 files changed, 152 insertions(+), 168 deletions(-) diff --git a/actions/class.ItemExport.php b/actions/class.ItemExport.php index ef9bbbb50..a791d54d9 100644 --- a/actions/class.ItemExport.php +++ b/actions/class.ItemExport.php @@ -1,4 +1,5 @@ getClassInstances(); if (!count($instances)) { - $returnValue = array_filter($returnValue, + $returnValue = array_filter( + $returnValue, static function (tao_models_classes_export_ExportHandler $handler) { return $handler instanceof tao_models_classes_export_RdfExporter; - }); + } + ); } diff --git a/actions/class.ItemRunner.php b/actions/class.ItemRunner.php index 6cc6da4bb..c2529b257 100755 --- a/actions/class.ItemRunner.php +++ b/actions/class.ItemRunner.php @@ -39,12 +39,12 @@ public function index() $lang = $this->getSession()->getDataLanguage(); if ($this->hasRequestParameter('serviceCallId')) { - $serviceCallId = $this->getRequestParameter('serviceCallId'); - $variableData = $this->getServiceLocator()->get(StateStorage::SERVICE_ID)->get($userId, $serviceCallId); - $this->setData('storageData', [ - 'serial' => $serviceCallId, - 'data' => is_null($variableData) ? [] : $variableData - ]); + $serviceCallId = $this->getRequestParameter('serviceCallId'); + $variableData = $this->getServiceLocator()->get(StateStorage::SERVICE_ID)->get($userId, $serviceCallId); + $this->setData('storageData', [ + 'serial' => $serviceCallId, + 'data' => is_null($variableData) ? [] : $variableData + ]); } $directory = $this->getDirectory($this->getRequestParameter('itemPath')); diff --git a/actions/class.Main.php b/actions/class.Main.php index f258ba32d..9682a6756 100644 --- a/actions/class.Main.php +++ b/actions/class.Main.php @@ -1,4 +1,5 @@ form->getElement($elementId); $ele->feed(); $modelUri = $ele->getEvaluatedValue(); - + if (empty($modelUri)) { // remove deprecated models $statusProperty = new core_kernel_classes_Property(ItemModelStatus::CLASS_URI); @@ -67,7 +67,7 @@ protected function initElements() $itemModelElt = tao_helpers_form_FormFactory::getElement($elementId, 'Hidden'); $itemModelElt->setValue($modelUri); $this->form->addElement($itemModelElt, true); - + // display model label $model = new core_kernel_classes_Resource($modelUri); $itemModelLabelElt = tao_helpers_form_FormFactory::getElement('itemModelLabel', 'Label'); diff --git a/actions/form/class.RestItemForm.php b/actions/form/class.RestItemForm.php index 3d32fce99..bb00b0b6d 100644 --- a/actions/form/class.RestItemForm.php +++ b/actions/form/class.RestItemForm.php @@ -19,8 +19,8 @@ * */ -use \Zend\ServiceManager\ServiceLocatorAwareTrait; -use \Zend\ServiceManager\ServiceLocatorAwareInterface; +use Zend\ServiceManager\ServiceLocatorAwareTrait; +use Zend\ServiceManager\ServiceLocatorAwareInterface; /** * Class tao_actions_form_RestItemForm diff --git a/helpers/class.Deployment.php b/helpers/class.Deployment.php index b6fc06023..43fc38dd7 100755 --- a/helpers/class.Deployment.php +++ b/helpers/class.Deployment.php @@ -1,4 +1,5 @@ 0; } - + /** * Retrieve