Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails on node 20 (node-sass version in package-lock.json stops working after node 18) #362

Open
jpmckinney opened this issue May 8, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@jpmckinney
Copy link
Contributor

jpmckinney commented May 8, 2023

Context (Environment)

All in issue title.

Expected Behavior

Build succeeds on node 20.

Actual Behavior

Build fails on node 20.

To Reproduce

npm run build:main && npm run build:inline on node 20.

Additional Information

N/A

Possible Solution

Not sure - maybe have branches/releases for node20 and node18, since they require different package-lock.json.

My current workaround is just to lock the engine to 18 in both package files (smallest edit).

@jpmckinney jpmckinney added the bug Something isn't working label May 8, 2023
@afischer
Copy link
Member

afischer commented May 8, 2023

Hi @jpmckinney, thanks for the issue. We currently we officially support 14.x, 16.x, 18.x, but will definitely look into getting node 20 working now that it's LTS!

@Morred
Copy link

Morred commented Jun 21, 2023

I'm actually experiencing this on node 16 as well, even though it's officially supported. The only way I was able to fix it was to completely replace node-sass (which is deprecated anyways) with dart-sass. I can make a PR if that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants