Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\OCA\Calendar\Service\Appointments\BookingCalendarWriter depends on Sabre #3728

Open
ChristophWurst opened this issue Nov 26, 2021 · 3 comments
Assignees
Labels

Comments

@ChristophWurst
Copy link
Member

ChristophWurst commented Nov 26, 2021

Expected behavior

Our app only uses its own code, or directly dependent libraries

Actual behavior

Server's 3rdparty library is used

Possible solution

  • Ship another lib for the same purpose
  • Ship our own, scoped version of Sabre

Calendar app

Calendar app version: v3


cc @miaulalala

additional code from #5339 needs refactoring too.

@tcitworld
Copy link
Member

tcitworld commented Nov 26, 2021

We could even generate the whole ICS ourselves manually as there's nothing special about it, and no logic to apply, only injecting variables in a template.

@miaulalala
Copy link
Contributor

Unless it's linebreaks - any ideas on how to correctly handle a long description? Or special chars possibly like emojis? We'd have to filter those I guess.

@tcitworld
Copy link
Member

Description should be handled with
https://github.com/sabre-io/vobject/blob/0a2e27c797ec0934f376764e1a16567bbbcece0b/lib/Property/Text.php#L261-L272

The rest is UTF8 :)
https://datatracker.ietf.org/doc/html/rfc5545#section-3.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📄 To do
Development

No branches or pull requests

3 participants