Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve all todos in contentrepository-90.php #75

Open
mhsdesign opened this issue Jun 27, 2024 · 0 comments
Open

Solve all todos in contentrepository-90.php #75

mhsdesign opened this issue Jun 27, 2024 · 0 comments

Comments

@mhsdesign
Copy link
Member

There are way more todos declared in the source than real issues in this repo.

so just to give awareness to that.

Every comment that is NOT marked with -> compatible with ES CR Node (nothing to do) is missing a migration!

That includes all methods on the TraversableNodeInterface

/**
* Neos\ContentRepository\Domain\Projection\Content\TraversableNodeInterface
*/
// getDimensionSpacePoint() -> threw exception in <= Neos 8.0 - so nobody could have used this
// findParentNode() -> TraversableNodeInterface
$rectorConfig->rule(NodeFindParentNodeRector::class);
// findNodePath() -> NodePath
// TODO: PHP
// findNamedChildNode(NodeName $nodeName): TraversableNodeInterface;
// TODO: PHP
// findChildNodes(NodeTypeConstraints $nodeTypeConstraints = null, int $limit = null, int $offset = null): TraversableNodes;
// TODO: PHP
// countChildNodes(NodeTypeConstraints $nodeTypeConstraints = null): int;
// TODO: PHP
// findReferencedNodes(): TraversableNodes;
// TODO: PHP
// findNamedReferencedNodes(PropertyName $edgeName): TraversableNodes;
// TODO: PHP
// findReferencingNodes() -> threw exception in <= Neos 8.0 - so nobody could have used this
// findNamedReferencingNodes() -> threw exception in <= Neos 8.0 - so nobody could have used this

As well as moving

// moveBefore()
// moveAfter()
// moveInto()
// copyBefore()
// copyAfter()
// copyInto()

and creating nodes:

// createNode
// createSingleNode -> internal
// createNodeFromTemplate

And much more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant