Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement and document server-side configuration #4

Closed
krassowski opened this issue May 23, 2024 · 1 comment · Fixed by #8
Closed

Implement and document server-side configuration #4

krassowski opened this issue May 23, 2024 · 1 comment · Fixed by #8
Assignees

Comments

@krassowski
Copy link
Member

krassowski commented May 23, 2024

The configuration file with links to repositories, descriptions, etc can be either a custom toml/json/yaml file or a traitlet (py/json file); the question here boils down to preferences on file format, and:

  • if we use a traitlet we can re-use the jupyter-server config files (py/json); the python files could read in the PAT token from environment variables and embed it in the repository URL used for cloning
  • if we use a custom file (toml/yaml/json), we will need to implement variable substitution

Originally posted in nebari-dev/nebari#2456 (comment)

Note: It cannot be placed in a JupyterLab JSON overrides as these are client-side and would expose PATs

@krassowski
Copy link
Member Author

There needs to be a way to setup it via nebari config; if it is a traitlet, then maybe nebari should have a sibling entry to jupyterlab.default_settings but for the server-side settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant