Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that this works when ssh key is not available #1

Open
krassowski opened this issue May 22, 2024 · 1 comment
Open

Make sure that this works when ssh key is not available #1

krassowski opened this issue May 22, 2024 · 1 comment

Comments

@krassowski
Copy link
Member

The git@github.com:nebari-dev/nebari.git format works well when ssh key is setup but not when using an anonymous git user - in that case https://github.com/nebari-dev/nebari.git is needed.

Traceback (most recent call last): File "/srv/conda/envs/notebook/lib/python3.10/site-packages/nbgitpuller/pull.py", line 118, in resolve_default_branch head_branch = subprocess.run( File "/srv/conda/envs/notebook/lib/python3.10/subprocess.py", line 526, in run raise CalledProcessError(retcode, process.args, subprocess.CalledProcessError: Command '['git', 'ls-remote', '--symref', '--', 'git@github.com:nebari-dev/nebari.git', 'HEAD']' returned non-zero exit status 128. During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/srv/conda/envs/notebook/lib/python3.10/site-packages/jupyterlab_gallery/gitpuller.py", line 81, in _pull gp = GitPuller(repo, repo_dir, branch=branch, depth=depth, parent=self.settings['nbapp']) File "/srv/conda/envs/notebook/lib/python3.10/site-packages/nbgitpuller/pull.py", line 79, in __init__ self.branch_name = self.resolve_default_branch() File "/srv/conda/envs/notebook/lib/python3.10/site-packages/nbgitpuller/pull.py", line 134, in resolve_default_branch raise ValueError(m) ValueError: Problem accessing HEAD branch: git@github.com:nebari-dev/nebari.git
@krassowski
Copy link
Member Author

We will need to improve URL parsing so that we can switch a valid git URL given in one format to another format but using the protocol that we need. It is easy but probably time consuming and requires writing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant