-
-
Notifications
You must be signed in to change notification settings - Fork 3
/
index.js
519 lines (465 loc) · 17.9 KB
/
index.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
import core from "@actions/core";
import github from "@actions/github";
import parseDiff from "parse-diff";
import OpenAI from "openai";
import Anthropic from "@anthropic-ai/sdk";
import { zodResponseFormat } from "openai/helpers/zod";
import { z } from "zod";
import { zodToJsonSchema } from "zod-to-json-schema";
import mm from "micromatch";
import { aDiff, diffPayloadSchema } from "./utils/types.js";
import { DEFAULT_MODEL, COMMON_SYSTEM_PROMPT, FILES_IGNORED_BY_DEFAULT } from "./utils/constants.js";
/**
* @typedef {import("@actions/github/lib/utils").GitHub} GitHub
* @typedef {z.infer<typeof aDiff>[]} rawCommentsPayload
* @typedef {z.infer<typeof diffPayloadSchema>} suggestionsPayload
* @typedef {{ path: string, line: number, body: string }[]} CommentsPayload
* @typedef {InstanceType<GitHub>} OctokitApi
* @typedef {parseDiff.File[]} ParsedDiff
* @typedef {{ body: string | null }} PullRequestContext
* @typedef {{
* info: (message: string) => void,
* warning: (message: string) => void,
* error: (error: string) => void
* }} Logger
*/
/**
* @param {string} name
* @param {'openai' | 'anthropic'} platform
* @returns {string}
*/
function getModelName(name, platform) {
return name !== "" ? name : DEFAULT_MODEL[`${platform.toUpperCase()}`].name;
}
function extractComments() {
/**
* @param {ParsedDiff} parsedDiff
* @returns {rawCommentsPayload}
*/
const rawComments = parsedDiff =>
parsedDiff.reduce((acc, file) => {
const filePath = file.deleted ? file.from : file.to;
let diffRelativePosition = 0;
return acc.concat(
file.chunks.reduce((accc, chunk, i) => {
if (i !== 0) {
diffRelativePosition++;
}
return accc.concat(
chunk.changes
.map(change => {
return {
...change,
relativePosition: ++diffRelativePosition,
};
})
.filter(
change =>
change.type !== "normal" && !change.content.includes("No newline at end of file")
)
.map((change, i, arr) => {
if (change.content === "+" || change.content === "-") {
return null;
}
if (change.type === "add") {
/**
* It checks if the current change (change) is an addition that immediately follows a deletion (arr[i - 1].type === 'del') on the same line (change.ln === arr[i - 1].ln).
*/
if (i > 0 && arr[i - 1].type === "del" && change.ln === arr[i - 1].ln) {
return {
path: filePath,
position: change.relativePosition,
line: change.ln,
change,
previously: arr[i - 1].content,
};
}
return {
path: filePath,
position: change.relativePosition,
line: change.ln,
change,
};
}
if (
i < arr.length - 1 &&
change.type === "del" &&
change.ln === arr[i + 1].ln &&
arr[i + 1].type === "add"
) {
return null;
}
return {
path: filePath,
position: change.relativePosition,
line: change.ln,
change,
};
})
.filter(i => i) /** filter out nulls */
);
}, [])
);
}, []);
/**
* @param {rawCommentsPayload} rawComments
* @param {string[]} filesToIgnore
* @returns {rawCommentsPayload}
*/
const filteredRawComments = (rawComments, filesToIgnore) =>
rawComments.filter(comment => {
return !mm.isMatch(comment.path, filesToIgnore, { dot: true });
});
/**
* @param {suggestionsPayload} suggestions
* @returns {CommentsPayload}
*/
const commentsWithSuggestions = suggestions =>
suggestions.commentsToAdd
.filter(i => i["suggestions"])
.map(i => {
return {
path: i.path,
// position: i.position,
line: i.line,
body: i.suggestions,
};
});
return {
raw: rawComments,
filteredRaw: filteredRawComments,
comments: commentsWithSuggestions,
};
}
/**
* @param {string} rules
* @param {rawCommentsPayload} rawComments
* @param {PullRequestContext} pullRequestContext
* @returns {string}
*/
function getUserPrompt(rules, rawComments, pullRequestContext) {
return `I want you to code review a pull request ${rules ? ` by including the following rules: ${rules} \nThe rules provided describe how the code should be` : ""}. Here's the diff payload from the pull request:
${JSON.stringify(rawComments)}
${pullRequestContext.body ? `\nAlso, here's the pull request description on what it's trying to do to give you some more context (keep in mind that the description is not always accurate and can be incorrect, so compare the code changes in the diff to the description): ${pullRequestContext.body})` : ""}`;
}
/**
* @param {{
* rawComments: rawCommentsPayload,
* openAI: OpenAI,
* rules: string,
* modelName: string,
* pullRequestContext: PullRequestContext
* }} params
* @returns {Promise<suggestionsPayload | null>}
*/
async function useOpenAI({ rawComments, openAI, rules, modelName, pullRequestContext }) {
const result = await openAI.beta.chat.completions.parse({
model: getModelName(modelName, "openai"),
messages: [
{
role: "system",
content: COMMON_SYSTEM_PROMPT,
},
{
role: "user",
content: getUserPrompt(rules, rawComments, pullRequestContext),
},
],
response_format: zodResponseFormat(diffPayloadSchema, "json_diff_response"),
});
const { message } = result.choices[0];
if (message.refusal) {
throw new Error(`the model refused to generate suggestions - ${message.refusal}`);
}
return message.parsed;
}
/**
* @param {{
* rawComments: rawCommentsPayload,
* anthropic: Anthropic,
* rules: string,
* modelName: string,
* pullRequestContext: PullRequestContext
* }} params
* @returns {Promise<suggestionsPayload | null>}
*/
async function useAnthropic({ rawComments, anthropic, rules, modelName, pullRequestContext }) {
const { definitions } = zodToJsonSchema(diffPayloadSchema, "diffPayloadSchema");
const result = await anthropic.messages.create({
max_tokens: 8192,
model: getModelName(modelName, "anthropic"),
system: COMMON_SYSTEM_PROMPT,
tools: [
{
name: "structuredOutput",
description: "Structured Output",
input_schema: definitions["diffPayloadSchema"],
},
],
tool_choice: {
type: "tool",
name: "structuredOutput",
},
messages: [
{
role: "user",
content: getUserPrompt(rules, rawComments, pullRequestContext),
},
],
});
let parsed = null;
for (const block of result.content) {
if (block.type === "tool_use") {
parsed = block.input;
break;
}
}
return parsed;
}
/**
* @param {{
* platform: 'openai' | 'anthropic',
* rawComments: rawCommentsPayload,
* platformSDK: OpenAI | Anthropic,
* rules: string,
* modelName: string,
* pullRequestContext: PullRequestContext
* }} params
* @returns {Promise<suggestionsPayload | null>}
*/
async function getSuggestions({ platform, rawComments, platformSDK, rules, modelName, pullRequestContext }) {
const { error } = log({ withTimestamp: true }); // eslint-disable-line no-use-before-define
try {
if (platform === "openai") {
return await useOpenAI({
rawComments,
openAI: platformSDK,
rules,
modelName,
pullRequestContext,
});
}
if (platform === "anthropic") {
return await useAnthropic({
rawComments,
anthropic: platformSDK,
rules,
modelName,
pullRequestContext,
});
}
throw new Error(`Unsupported AI platform: ${platform}`);
} catch (err) {
if (err.constructor.name == "LengthFinishReasonError") {
error(`Too many tokens: ${err.message}`);
core.setFailed(`Too many tokens: ${err.message}`);
} else {
error(`Could not generate suggestions: ${err.message}`);
core.setFailed(`Could not generate suggestions: ${err.message}`);
}
return null;
}
}
/**
* @param {rawCommentsPayload} rawComments
* @param {CommentsPayload} comments
* @returns {CommentsPayload}
*/
function filterPositionsNotPresentInRawPayload(rawComments, comments) {
return comments.filter(comment =>
rawComments.some(rawComment => rawComment.path === comment.path && rawComment.line === comment.line)
);
}
/**
* @param {suggestionsPayload} suggestions
* @param {OctokitApi} octokit
* @param {rawCommentsPayload} rawComments
* @param {string} modelName
*/
async function addReviewComments(suggestions, octokit, rawComments, modelName) {
const { info } = log({ withTimestamp: true }); // eslint-disable-line no-use-before-define
const comments = filterPositionsNotPresentInRawPayload(rawComments, extractComments().comments(suggestions));
try {
await octokit.rest.pulls.createReview({
owner: github.context.repo.owner,
repo: github.context.repo.repo,
pull_number: github.context.payload.pull_request.number,
body: `Code Review by ${modelName}`,
event: "COMMENT",
comments,
});
} catch (error) {
info(`Failed to add review comments: ${JSON.stringify(comments, null, 2)}`);
throw error;
}
}
/**
* @param {OctokitApi} octokit
* @param {{ mode: 'diff' | 'json' }} options
*/
async function getPullRequestDetails(octokit, { mode }) {
let AcceptFormat = "application/vnd.github.raw+json";
if (mode === "diff") AcceptFormat = "application/vnd.github.diff";
if (mode === "json") AcceptFormat = "application/vnd.github.raw+json";
return await octokit.rest.pulls.get({
owner: github.context.repo.owner,
repo: github.context.repo.repo,
pull_number: github.context.payload.pull_request.number,
headers: {
accept: AcceptFormat,
},
});
}
/**
* @param {OctokitApi} octokit
*/
async function getAllReviewsForPullRequest(octokit) {
return await octokit.rest.pulls.listReviews({
owner: github.context.repo.owner,
repo: github.context.repo.repo,
pull_number: github.context.payload.pull_request.number,
});
}
/**
* @param {OctokitApi} octokit
* @param {number} review_id
*/
async function getAllCommentsUnderAReview(octokit, review_id) {
return await octokit.rest.pulls.listCommentsForReview({
owner: github.context.repo.owner,
repo: github.context.repo.repo,
pull_number: github.context.payload.pull_request.number,
review_id,
});
}
/**
* @param {OctokitApi} octokit
* @param {number} comment_id
*/
async function deleteComment(octokit, comment_id) {
await octokit.rest.pulls.deleteReviewComment({
owner: github.context.repo.owner,
repo: github.context.repo.repo,
comment_id,
});
}
/**
* @param {string} value
* @returns {boolean}
*/
function getBooleanValue(value) {
if (!value || value === "") return false;
return value.toLowerCase() === "true";
}
/**
* @param {{ withTimestamp: boolean }} options
* @returns {Logger}
*/
function log({ withTimestamp = true }) {
/**
* @param {string} str
* @returns {string}
*/
const getLogText = str => (withTimestamp ? `[${new Date().toISOString()}]: ${str}` : str);
return {
info: message => core.info(getLogText(message)),
warning: message => core.warning(getLogText(message)),
error: error => core.error(getLogText(error)),
};
}
async function run() {
const { info, warning, error } = log({ withTimestamp: true });
try {
info("Retrieving tokens and inputs...");
const deleteExistingReviews = core.getInput("delete-existing-review-by-bot");
const rules = core.getInput("rules");
const token = core.getInput("repo-token");
const modelName = core.getInput("ai-model-name");
const modelToken = core.getInput("ai-model-api-key");
const platform = core.getInput("platform");
const filesToIgnore = core.getInput("filesToIgnore");
const octokit = github.getOctokit(token);
info("Initializing AI model...");
const platformSDK =
platform === "openai"
? new OpenAI({ apiKey: modelToken })
: new Anthropic({
apiKey: modelToken,
});
if (github.context.payload.pull_request) {
info("Fetching pull request details...");
const pullRequestDiff = await getPullRequestDetails(octokit, {
mode: "diff",
});
const pullRequestData = await getPullRequestDetails(octokit, {
mode: "json",
});
if (getBooleanValue(deleteExistingReviews)) {
info("Preparing to delete existing comments...");
info("Fetching pull request reviews...");
const reviews = await getAllReviewsForPullRequest(octokit);
info(`Fetching reviews by bot...`);
const reviewsByBot = reviews.data.filter(
r => r.user.login === "github-actions[bot]" || r.user.type === "Bot"
); // not possible to change the bot name - https://github.com/orgs/community/discussions/25853
if (reviewsByBot.length > 0) {
info(`Found ${reviewsByBot.length} reviews by bot...`);
warning("Deleting existing comments for all reviews by bot...");
for (const review of reviewsByBot) {
const reviewComments = await getAllCommentsUnderAReview(octokit, review.id);
for (const comment of reviewComments.data) {
await deleteComment(octokit, comment.id);
await new Promise(resolve => setTimeout(resolve, 1500)); // Wait 1.5 seconds before deleting next comment to avoid rate limiting
}
}
} else {
info("No reviews by bot found. Skipping deleting existing comments for all reviews by bot...");
}
} else {
info("Skipping deleting existing comments for all reviews by bot...");
}
info(`Reviewing pull request ${pullRequestDiff.url}...`);
const parsedDiff = parseDiff(pullRequestDiff.data);
const rawComments = extractComments().raw(parsedDiff);
info("Getting files to ignore...");
const filesToIgnoreList = [
...new Set(
filesToIgnore
.split(";")
.map(file => file.trim())
.filter(file => file !== "")
.concat(FILES_IGNORED_BY_DEFAULT)
),
];
const filteredRawComments = extractComments().filteredRaw(rawComments, filesToIgnoreList);
info(`Generating suggestions using model ${getModelName(modelName, platform)}...`);
const suggestions = await getSuggestions({
platform,
rawComments: filteredRawComments,
platformSDK,
rules,
modelName,
pullRequestContext: {
body: pullRequestData.data.body,
},
});
if (!suggestions) {
warning("Could not generate suggestions. Refer to the error log for more information and try again.");
return;
}
if (suggestions.commentsToAdd.length === 0) {
info("No suggestions found. Code review complete. All good!");
return;
}
info("Adding review comments...");
await addReviewComments(suggestions, octokit, filteredRawComments, getModelName(modelName, platform));
info("Code review complete!");
} else {
warning("Not a pull request, skipping...");
}
} catch (err) {
error(err);
core.setFailed(err.message);
}
}
run();