Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: #174

Closed
kephale opened this issue Jun 5, 2023 · 2 comments
Closed

Feature request: #174

kephale opened this issue Jun 5, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@kephale
Copy link
Member

kephale commented Jun 5, 2023

Is your feature request related to a problem? Please describe.

Some IJ2 Commands in SNT cannot be discovered in napari-imagej, like SkeletonizerCmd. Ran into this here imagej/napari-imagej#262

Describe the solution you'd like

Can the Commands in sc.fiji.snt.plugin be changed to have visible = true?

Describe alternatives you've considered

Unclear what the alternatives would be.

Additional context

Trying to expose SNT through napari-imagej

@tferr
Copy link
Member

tferr commented Jun 11, 2023

with visible = true they appear in the Quick Search... results (that search bar in Fiji, written by Curtis et al). It is silly to have the commands picked up in searched because they are not registered in the ImageJ UI, and pressing Run on a searched SNT command is a guaranteed failure since the inputs won't be properly defined.

But napari support is way more important! so I tried to make the bulk of them visible with 9ad2b61 (I think I toggled the visibility of most commands, but do let me know if I have missed some).

Any problems caused by search results in Fiji can be tracked here: scijava/scijava-search#31

@tferr
Copy link
Member

tferr commented Jun 11, 2023

v4.1.20 has been released with this change! (BTW: In this version core classes no longer rely on LegacyService: I kept running (initialization errors) into issues with pyimagej related to LegacyService. Now that it is not needed, those are gone 😄 )

Closing this issue for now. We can always open it if something is needed

@tferr tferr closed this as completed Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants