Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verify's callback function does not conform to Node.js standards #8

Open
cappslock opened this issue Feb 4, 2013 · 0 comments
Open

verify's callback function does not conform to Node.js standards #8

cappslock opened this issue Feb 4, 2013 · 0 comments

Comments

@cappslock
Copy link

Callback functions in Node.js are generally of the format

function (error, otherParameter) {}

But the verify method uses the format

function (success, error_code) {}

This seems unnecessary, as success can easily be indicated by the absence of an error code.
@cappslock cappslock mentioned this issue Feb 4, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cappslock