Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Consistent Use of MeshKit Errors in meshery-nginx-sm #288

Open
2 tasks
singh1203 opened this issue Aug 8, 2024 · 10 comments
Open
2 tasks

Ensure Consistent Use of MeshKit Errors in meshery-nginx-sm #288

singh1203 opened this issue Aug 8, 2024 · 10 comments
Assignees
Labels
good first issue Good for newcomers kind/enhancement Improvement in current feature language/go Golang related

Comments

@singh1203
Copy link

Current Behavior

Currently, there are instances where errors are being used directly instead of MeshKit errors, which impacts the consistency and quality of error reporting across the project.

Desired Behavior

  • Replace all direct usages of errors with MeshKit errors.
  • Ensure that each MeshKit error includes:- Short Description, Long Description, Probable Cause & Suggested Remediation.

References

Meshery Documentation on Meshkit


Contributor Guides and Resources

@singh1203 singh1203 added good first issue Good for newcomers kind/enhancement Improvement in current feature language/go Golang related labels Aug 8, 2024
@Sylani-55
Copy link

Hi @singh1203 I'm a beginner and I want to give a try to solving this issue what are prerequisites for solving this issue?? I'm familiar with Error handling in Golang any other things should I learn it would be helpful for me to solve the issue
Thanks and Regards!!

@ShivanshuGupta07
Copy link

Hi @singh1203, can I take this one

@singh1203
Copy link
Author

Hi @singh1203 I'm a beginner and I want to give a try to solving this issue what are prerequisites for solving this issue?? I'm familiar with Error handling in Golang any other things should I learn it would be helpful for me to solve the issue Thanks and Regards!!

Thanks for your inquiry, @Sylani-55. Please make sure to run the repository locally and review the mentioned documentation.

@singh1203
Copy link
Author

Hi @singh1203, can I take this one

Thanks for hopping in @ShivanshuGupta07, but we follow FCFS. Maybe you can review the PR or find similar ones missing in other repositories as well.

@ShivanshuGupta07
Copy link

No Problem @singh1203, I will definitely try to find some other "good first issue"

@singh1203
Copy link
Author

@Sylani-55 Just following up, please provide an update on the progress.

@Sylani-55
Copy link

Hi Sourabh Singh,

Thank you for checking in. I apologize for the delay in resolving the issue. I've been working on it and have made some progress, but I'm not quite finished yet.

I plan to dedicate more time over the next few days and aim to have it completed by this Sunday. I appreciate your understanding and will keep you posted if anything changes.

Please let me know if there's anything else you'd like me to focus on.

Best regards,
Syed

@leecalcote
Copy link
Member

@Sylani-55, checking in... it'd be good to get an update on this from you.

@aarochuk
Copy link

aarochuk commented Oct 7, 2024

Hello @Sylani-55 @leecalcote is there any update in this ticket I desire to provide assistance or take over the ticket if necessary.

@leecalcote leecalcote assigned aarochuk and unassigned Sylani-55 Oct 7, 2024
@leecalcote
Copy link
Member

Not having heard from, @Sylani-55, yes, thank you for raising your hand, @aarochuk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/enhancement Improvement in current feature language/go Golang related
Projects
None yet
Development

No branches or pull requests

5 participants