Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to emojione 4.5 #436

Open
DanielVip3 opened this issue Jun 9, 2021 · 6 comments
Open

Upgrading to emojione 4.5 #436

DanielVip3 opened this issue Jun 9, 2021 · 6 comments

Comments

@DanielVip3
Copy link

DanielVip3 commented Jun 9, 2021

Well, since @mervick is busy and probably switching to joypixels/emoji-toolkit would be time-consuming, it would be nice to have at least an upgrade to emojione 4.5, which includes the 157 new emojis of Emoji 11.0.

I tried using useInternalCDN: false and loading emojione@4.5 manually, but it seems the lib still uses the old 3.1 emoji images URL and probably doesn't include the new emojis in the picker too.

I can help with it, if @mervick is interested, I'd try upgrading the lib and making a PR.

@mervick
Copy link
Owner

mervick commented Jun 10, 2021

Hello. If you will create PR I will merge it.
Thank you

@lamweili
Copy link

lamweili commented Oct 2, 2021

@DanielVip3, I tried emojione 4.5 and emojionearea 3.4.2 with useInternalCDN: false.

  • The new emojis (partial from emojione 3.1 and all from emojione 4.0 are not included in the picker.
    While I can find 3.1 🤯 (exploding_head), I couldn't find 3.1 🤪 (zany_face) and 4.0 🥵 (hot_face).
    New emojis' name have to be added to the defaultOptions.filters in src/function/getDefaultOptions.js.
    I believe this requires a PR which @mervick will merge and build the dist folder.

  • For the existing emojis, the library already uses the emojione 4.5 updated images.
    I identified by 🚡 (aerial_tramway).

For my scenario, I extracted the 4 zip archives (mentioned in the code below) and place them in a libraries folder.

<!-- emojionearea pre-req: emojione 4.5.0 -->
<!-- src: https://github.com/joypixels/emojione/archive/refs/tags/4.5.0.zip -->
<link rel="stylesheet" href="../libraries/emojione-4.5.0/extras/css/emojione.min.css">
<script src="../libraries/emojione-4.5.0/lib/js/emojione.min.js"></script>

<!-- emojione offline assets: emojione-assets 4.5 -->
<!-- src: https://github.com/joypixels/emojione-assets/archive/refs/tags/4.5.zip -->
<script type="text/javascript">
  /* global emojione */
  // https://github.com/joypixels/emojione/blob/master/USAGE.md
  emojione.imagePathPNG = "../libraries/emojione-assets-" + emojione.emojiVersion + "/png/" + emojione.emojiSize + "/";
</script>

<!-- emojionearea pre-req: jquery.textcomplete 1.3.4 -->
<!-- src: https://github.com/yuku/textcomplete/archive/refs/tags/jquery-v1.3.4.zip) -->
<script src="../libraries/textcomplete-jquery-v1.3.4/dist/jquery.textcomplete.min.js"></script>

<!-- emojionearea v1.3.4 -->
<!-- src: https://github.com/mervick/emojionearea/archive/refs/tags/v3.4.2.zip) -->
<link rel="stylesheet" href="../libraries/emojionearea-3.4.2/dist/emojionearea.min.css">
<script src="../libraries/emojionearea-3.4.2/dist/emojionearea.min.js"></script>

@Maikuolan
Copy link

Last reply here was October 2021. Out of curiosity, any further progress on this since then?

@mervick
Copy link
Owner

mervick commented Jul 25, 2022

@Maikuolan Sorry about that. I don't have much time to do this, especially after Russia invaded my country. I could not even do my main paid job for months because of war...

Any pull requests are welcome.

@Maikuolan
Copy link

Maikuolan commented Jul 25, 2022

No stress, and totally understandable. :-)

Please stay safe. We all love seeing progress at open-source projects like these, but life and personal safety is always much more important than that, or than anything else. Anything else can wait.

Also, because there are multiple people participating at this issue, I figure, better to ask first, instead of assuming anything. I could try doing something in my spare time, but I've come to this issue more than a year late since it first started, and maybe some other people have already started working on this in their own spare time, and there is already work in progress, but I just can't see it, because there aren't any draft PRs or things like that yet? If that's the case, better to just wait instead of trying to do work which is already being done.

@lamweili
Copy link

@Maikuolan, while I didn't get started on anything, I hope my previous comment, #436 (comment), provides you with some direction to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants