New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH - add warning in `PN_logreg` for unhandled case #240

Open

Badr-MOUFAD opened this issue Apr 22, 2022 · 0 comments · May be fixed by #241

Collaborator

Badr-MOUFAD commented Apr 22, 2022

I think this is a dangerous design as it silences eventual errors/bugs.
I suggest raising a warning in this case.

celer/celer/PN_logreg.pyx

Lines 426 to 428 in 83c4628

    
           else: 
        
               pass 
        
               # TODO what do we do in this case?

mathurinm changed the title ~~ENH - add warning in PN_LogReg for unhandled case~~ ENH - add warning in PN_logreg for unhandled case

Badr-MOUFAD linked a pull request

that will close this issue

ENH - add warning in PN_logreg for unhandled case #241

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment