Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler get, update and remove #229

Open
olimortimer opened this issue Feb 13, 2018 · 3 comments
Open

Simpler get, update and remove #229

olimortimer opened this issue Feb 13, 2018 · 3 comments

Comments

@olimortimer
Copy link

I'm looking at which cart package to use, and have been comparing laracart to laravelshoppingcart - https://github.com/darryldecode/laravelshoppingcart

I like how laracart can handle coupons etc, but can't help thinking the way to get / update and remove items is a little clunky, as you first have to find the item by the ID, for example, get the hash, then update or remove using the hash. Is there any reason why there couldn't be a simpler method using the ID to get / update / remove the item, even if it did the find for us behind the scenes?

laravelshoppingcart seems to use this method, which makes it a lot simpler to do tasks such as increasing quantity, or removing items from the session. It even has a way of updating a specific user's cart, which could be handy for admins to assist users by adding items remotely.

@lukepolo
Copy link
Owner

@olimortimer Yah it probably could be a lot simpler, I 100% agree.

Id be more than welcome for a PR for this type of thing, I just don't have the time to upgrade this package to a newer version with a way better API.

@olimortimer
Copy link
Author

Does that mean development isn't continuing on laracart?

@lukepolo
Copy link
Owner

I still support it , i do some work on it from time to time. But its not at the top of my list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants