Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests (in fullcheck) failing to compile #228

Open
bdsaunders opened this issue Aug 7, 2019 · 1 comment
Open

tests (in fullcheck) failing to compile #228

bdsaunders opened this issue Aug 7, 2019 · 1 comment

Comments

@bdsaunders
Copy link
Member

test-ntl-toeplitz and test-ntl-hankel fail due to disappearance of Method::Shape
test-smith-form-binary fails due to lack of testRandom
test-rational-reconstruction-base fails due to lack of powtwo in Givaro::ZRingGivaro::Integer
@bdsaunders
Copy link
Member Author

Pushed fixes directly to master. Future work (will make separate issues/branches):

  1. fix smith form binary (in particular, often second smallest invariant is garbage)
  2. clean up toeplitz and hankel a little.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bdsaunders