Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring backend using typescript #3

Closed
DSAghicha opened this issue Oct 28, 2023 · 24 comments · Fixed by #466
Closed

Refactoring backend using typescript #3

DSAghicha opened this issue Oct 28, 2023 · 24 comments · Fixed by #466
Assignees
Labels
good first issue Good for newcomers gssoc Issue can be taken under GSSoC level2

Comments

@DSAghicha
Copy link

No description provided.

@krishnaacharyaa
Copy link
Owner

Please add description, though the title explains the issue :)

@DSAghicha
Copy link
Author

I would like to implement a SOA using OOPs in TypeScript where the architecture will be like as follows:
image

@krishnaacharyaa
Copy link
Owner

Sure, but presently we already have decent folder architecture which has good seperation of concerns as below
image

How does project benefit by using the above SOA architecture, because we are not having multiple services even in the near future, so I feel clean architecture would be a perfect fit here in terms of architecture than SOA.

@krishnaacharyaa
Copy link
Owner

For now may be we can refactor the backend to use ts instead of js and leave the architecture for now as suggested in the title of the issue

@MunavvarSinan
Copy link

Is anyone doing this? If not could you please assign this to me

@bajajcodes
Copy link
Collaborator

Hey @krishnaacharyaa I can take this and migrate backend in one go to typescript and later on gradually as people get comfortable they can start writing types for respective code.

A single pr to introduce typescript using ts-migrate something.

@krishnaacharyaa
Copy link
Owner

@shmbajaj yeah sure. We'll do this, I am working on integration tests for backend, as soon as that is merged, lets do this

@ppriyankuu
Copy link

I see the backend is yet to be converted into typescript. if no one's currently assigned then maybe I can take up the job.

@krishnaacharyaa
Copy link
Owner

Please tell the approach and ETA @ppriyankuu

@ppriyankuu
Copy link

ppriyankuu commented Apr 18, 2024

I can migrate the files to typescript with minimal types, and later as time goes eventually others can start writing their detailed extensive types.

It'll take a day. At max.

@krishnaacharyaa
Copy link
Owner

Sure please go ahead kindly follow PR guidelines

@ppriyankuu
Copy link

Sure!!

@amit429
Copy link
Contributor

amit429 commented May 14, 2024

@krishnaacharyaa Can you assign me this issue so i can try to make conversions and please give it a gssoc'24 tag and the level tag

@krishnaacharyaa krishnaacharyaa added gssoc Issue can be taken under GSSoC level2 labels May 14, 2024
@krishnaacharyaa
Copy link
Owner

@vamsidhar-914 would you like to take this?

@vamsidhar-914
Copy link
Contributor

Yeahh sure...I'll be on itt @krishnaacharyaa

@vamsidhar-914
Copy link
Contributor

hi @krishnaacharyaa

update: almost migrated all JS files to TS with all the types included , didnt touched tests as i didnt work on tests before, it might take some time to do,might use some help on the tests

@krishnaacharyaa
Copy link
Owner

Sure @vamsidhar-914, waiting for the PR

@vamsidhar-914
Copy link
Contributor

@krishnaacharyaa opened

vamsidhar-914 added a commit to vamsidhar-914/wanderlust that referenced this issue Jun 8, 2024
vamsidhar-914 added a commit to vamsidhar-914/wanderlust that referenced this issue Jun 8, 2024
@krishnaacharyaa
Copy link
Owner

@shivansh84ya can you take this up?

@krishnaacharyaa
Copy link
Owner

krishnaacharyaa commented Jul 3, 2024

You have to follow
#408 and #156 you would have to see and then cover the review comments that's it
@shivansh84ya let me know if this interests you

@krishnaacharyaa
Copy link
Owner

@shivansh84ya acknowledgement please. If you are not interested someone else will pick this up

@shivansh84ya
Copy link
Contributor

Hi @krishnaacharyaa,

I am ready to Refactoring backend using typescript. Could you please provide more details about this issue and any specific guidelines I should follow?

Thank you!

@krishnaacharyaa
Copy link
Owner

You have to follow #408 and #156 you would have to see and then cover the review comments that's it @shivansh84ya let me know if this interests you

@shivansh84ya .
Best practices of nodejs ts
And our normal contributing guidelines, nothing else apart from that ....!

Copy link

Hey @shivansh84ya 🎉! Thanks for jumping on this issue. Before you dive in, please check out our contributing guidelines to ensure we're all on the same page. Happy coding! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers gssoc Issue can be taken under GSSoC level2
Projects
None yet
8 participants