Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DIN5008: Twig deprecated attribute() #17

Open
kevinpapst opened this issue Sep 23, 2024 · 0 comments
Open

DIN5008: Twig deprecated attribute() #17

kevinpapst opened this issue Sep 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@kevinpapst
Copy link
Member

Hi @LiaraAlis

Twig is deprecating the attribute() function, see:
https://github.com/twigphp/Twig/blob/3.x/doc/deprecated.rst

You are using it in your DIN5008 template:
https://github.com/kimai/invoice-templates/blob/main/din5008-invoice/din5008-invoice.pdf.twig#L321

Maybe it can simply be replaced with array syntax?

<th class="invoice-details-label">{{ lineData[0] }}:</th>
<td class="invoice-details-value">{{ lineData[1] }}</td>
@kevinpapst kevinpapst added the invalid This doesn't seem right label Sep 23, 2024
@kevinpapst kevinpapst changed the title Twig deprecated attribute() DIN5008: Twig deprecated attribute() Sep 23, 2024
@kevinpapst kevinpapst added enhancement New feature or request and removed invalid This doesn't seem right labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevinpapst