-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] create a log!
macro
#187
Comments
Hi @maciejka can I please work on this? |
Hey @ShantelPeters! |
Hey @mubarak23! |
Do you have any Rust experience? |
Yes, checkout my Github profile here work on the following rust codebase
|
Hi @maciejka, can I work on this issue? I have fairly amount of experience in Rust. Thanks! https://github.com/paradigmxyz/reth/commits/main/?author=TropicalDog17 |
Hey @TropicalDog17! |
Hi, I've follow the scarb guild for writing procedural macros, but I can't manage to import in in Cairo code. here is the the file content is exactly the same as the example: https://docs.swmansion.com/scarb/docs/reference/procedural-macro.html#procedural-macro-packages-can-be-used-as-dependencies
@maciejka @m-kus any idea about this, will appreciate any help. Thank you! |
@TropicalDog17 create a draft pr please, we will have a look then. |
I've figured out @maciejka, but how to achieve
How to achieve the conditional compilation in Cairo, in rust I think we can get the feature value of config with |
Let's continue this discussion in the pr. |
Closing as features support in Scarb is not mature enough yet. |
Create a
log!
macro to improve debuggability. It should use scarb's procedural macro to create alog!
macro call:where arguments are:
log!
should useprintln!
under the hood to output messages.Logging level should be controlled by scarb features, i.e.: it should be possible to set current log level by setting log related feature:
log_level_trace
,log_level_debug
. No logging should be the default.Reading:
This issue requires Rust knowledge.
The text was updated successfully, but these errors were encountered: