Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO Limit the display of comet/sync warning to chrome browser only #117

Open
tyagishuchi1 opened this issue May 22, 2020 · 2 comments
Open
Assignees
Labels
enhancement Improvement on existing feature
Milestone

Comments

@tyagishuchi1
Copy link

The dApp displays a warning initially recommending users to either use Comet or Sync. Which makes sense in chrome browser but loses it's meaning in the Sync browser.

Expected Behavior

Warning message should only be shown if chrome browser is detected. And should not be shown in the Sync browser.

Current Behavior

Shows the warning message in both the browsers.
image

@tyagishuchi1 tyagishuchi1 added the enhancement Improvement on existing feature label May 22, 2020
@tyagishuchi1 tyagishuchi1 added this to the Oath Keeper milestone May 22, 2020
@ashishjur
Copy link

@MirelXhafa can you take this issue?
The new issue branch you can fork from feature/connex 👍 Once the changes are made, I'll merge the branch in feature/oath-keeper.

@ashishjur ashishjur removed their assignment Jun 3, 2020
@ashishjur ashishjur modified the milestones: Oath Keeper, Connex Jun 3, 2020
@marcomarasco
Copy link
Contributor

@tyagishuchi1 @ashishjur please note that the message appears also when you miss the sign for identification. Is a general message we used in previous version for both: Ask for downloading and tell user to unlock the wallet.

If @lucaydaniel agree we can change the message text only, leaving the implementation as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature
Projects
None yet
Development

No branches or pull requests

5 participants