-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention mobile/touch friendly #17
Comments
I tried on google chrome dev tools for ipad and other devices and does not work. Would love this feature if possible! |
The main obstacle to being mobile/touch friendly is the size of the hit targets. In particular, the separator is only 4px wide/tall by default. For now, it would be up to the developer to set a different value. However, I plan to explore the issue in more depth and probably provide an out of the box solution. For example, we could detect we're on a touch device and use a different default value (VS Code uses 20px in this situation). I'd be interested in hearing about any other mobile/touch issues you've experienced. |
There is a PR tracking initial work: #124. However, it is very rough and there is much work still to do. I'm not sure the payoff justifies the effort. |
I think the library is now working relatively well on iOS/iPadOS devices. This doesn't use the work in #124 but does include improvements around increasing the hit target size and sash size on suitable devices. If anyone with an Android device reading this could let me know if the mobile/touch support is working there I'd be grateful. I'll add some words to the README and website about this and mark this issue as closed. |
This does not work well on android devices when it comes to touch support. |
Purpose
As a developer I want to know this library will play nice with mobile and touch devices.
Proposal
Check this is true! If it is then add a line near the top of the README to this effect.
Acceptance criteria
The text was updated successfully, but these errors were encountered: