Syncing TV Shows write incorrect Provider ID, resulting in wrong Info in case of ID collisions #920

mihawk90 · 2024-09-23T01:26:41Z

Describe the bug
I am using Kodi's default skin Embuary. Since it doesn't show every piece of info available on a TV show, it has an "Extended Info" button in the TV Shows information, which then queries TMDB for additional information.
When browsing my library yesterday I noticed that on one show (The Mandalorian), it was pulling information for an entirely unrelated Anime (Ninja Nonsense), which I do not have in my library (nor in fact even knew about before).

After a bit of investigation, it appears that the data in Kodi's Library database is incorrectly entered, specifically:

idShow	c00	uniqueid_value	uniqueid_type
17	The Mandalorian	82856	tvdb

Note the uniqueid_type is set to tvdb, however the actual ID corresponds to the shows tMdb ID. Obviously the "Extended Info" button assumes the data in the database is correct, and so it queries TMDB using the TVDB-ID, which in turn points to Ninja Nonsense.

The addon should either actually enter the TVDB ID, or - preferably since Kodi is deprecating TVDB - use tmdb for the uniqueid_type.

I actually went through every show in my library, and out of 36 shows 6 (including Mando) were showing the same symptom:
https://www.thetvdb.com/dereferrer/series/71024 - Castlevania -> Young Lions
https://www.thetvdb.com/dereferrer/series/76479 - The Boys -> One Step Beyond
https://www.thetvdb.com/dereferrer/series/82856 - The Mandalorian -> Ninja Nonsense
https://www.thetvdb.com/dereferrer/series/86831 - Love, Death & Robots -> Throw Away the Moon
https://www.thetvdb.com/dereferrer/series/85271 - WandaVision -> Pedigree Dogs Exposed
https://www.thetvdb.com/dereferrer/series/81356 - Sex Education -> Zmiennicy

3 Shows were showing correctly:
https://www.thetvdb.com/dereferrer/series/293088 - One Punch Man - no ID in NFO
https://www.thetvdb.com/dereferrer/series/72832 - Kamikaze Kaitou Jeanne - no NFO
https://www.thetvdb.com/dereferrer/series/85249 - Fullmetal Alchemist Brotherhood - no ID in NFO

As you can see from the note, this seems to be connected to info pulled from NFOs.

All my shows have NFOs and all of them use TMDB's ID by default, i.e.:

    <originaltitle>The Mandalorian</originaltitle>
    <uniqueid default="true" type="tmdb">82856</uniqueid>
    <uniqueid type="tvdb">361753</uniqueid>
    <uniqueid type="imdb">tt8111088</uniqueid>
    <id>82856</id>

However, my animes don't have NFOs (yet), and so Jellyfin determined the IDs on its own. The TVDB IDs are not actually shown in Jellyfin anywhere.

For the rest of my shows the TMDB-IS is an invalid TVDB-ID, and so either Kodi or the TMDB API fall back to showing TMDB data, the uniqueid_type is incorrect nonetheless though.

Invalid IDs for reference

To Reproduce
This is using Kodis default skin Embuary, I have no idea how other skins handle this

Have one or more TV Shows with TMDB/TVDB ID collisions, examples see above
Said TV shows should have NFOs with TMDB defined as the default unique ID
Sync shows to Kodi
In Kodis TV Show Library open the show -> Context Menu -> Information -> Extended Info
You'll (hopefully?) be presented with the wrong TV Show info

Expected behavior
Kodi should show the correct Extended Info for the show

Logs
There's no errors, and I don't see it even logging opening the Extended info...
kodi.mando-ext.debug.log

Screenshots

System (please complete the following information):

OS: Windows/Xbox One
Jellyfin Version: 10.9.11
Kodi Version: 21.1
Addon Version: v1.0.5
Playback Mode: Addon

Additional context
I haven't dug super deep, but from what I can tell from here:

jellyfin-kodi/jellyfin_kodi/objects/kodi/queries.py

Lines 387 to 393 in 1637658

    
           add_unique_id_tvshow_obj = [ 
        
               "{Unique}", 
        
               "{ShowId}", 
        
               "tvshow", 
        
               "{UniqueId}", 
        
               "{ProviderName}", 
        
           ]

jellyfin-kodi/jellyfin_kodi/objects/tvshows.py

Lines 191 to 197 in 1637658

    
           def tvshow_add(self, obj): 
        
               """Add object to kodi.""" 
        
               obj["RatingId"] = self.create_entry_rating() 
        
               self.add_ratings(*values(obj, QU.add_rating_tvshow_obj)) 
        
               obj["Unique"] = self.create_entry_unique_id() 
        
               self.add_unique_id(*values(obj, QU.add_unique_id_tvshow_obj))

jellyfin-kodi/jellyfin_kodi/objects/tvshows.py

Line 138 in 1637658

self.tvshow_add(obj)

The query wants a ProviderName, but I don't see it ever added to the obj being passed, so it may be that Kodi itself just defaults to tvdb because nothing is provided?

I should also note this is a fresh database, it was reset a couple days ago and resynced to troubleshoot an unrelated issue.

The text was updated successfully, but these errors were encountered:

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Syncing TV Shows write incorrect Provider ID, resulting in wrong Info in case of ID collisions #920

Syncing TV Shows write incorrect Provider ID, resulting in wrong Info in case of ID collisions #920

mihawk90 commented Sep 23, 2024 •

edited

Loading

Syncing TV Shows write incorrect Provider ID, resulting in wrong Info in case of ID collisions #920

Syncing TV Shows write incorrect Provider ID, resulting in wrong Info in case of ID collisions #920

Comments

mihawk90 commented Sep 23, 2024 • edited Loading

mihawk90 commented Sep 23, 2024 •

edited

Loading