Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use uint16 for recording coverage information #151

Closed
leoisl opened this issue Jun 27, 2019 · 1 comment
Closed

Use uint16 for recording coverage information #151

leoisl opened this issue Jun 27, 2019 · 1 comment
Assignees
@leoisl
Labels
Performance

Comments

@leoisl
Copy link
Collaborator

leoisl commented Jun 27, 2019

Ok, let's switch to uint16 for coverage information then - almost no errors and half RAM usage for recording coverage information. Let's go for uint8 only if RAM becomes a bottleneck.

Originally posted by @leoisl in #148 (comment)
@leoisl leoisl self-assigned this Jun 27, 2019
@mbhall88
Copy link
Member

I don't think uint8_t would be a good idea. It is very common to have nanopore datasets with over 255x coverage.
But absolutely agree with the change to uint16_t

@leoisl leoisl mentioned this issue Jun 28, 2019
Merged
rmcolq pushed a commit that referenced this issue Jul 3, 2019
#151
ffc8740
@rmcolq rmcolq closed this as completed Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leoisl leoisl

Labels
Performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@leoisl @rmcolq @mbhall88