diff --git a/packages/melos/lib/src/commands/version.dart b/packages/melos/lib/src/commands/version.dart index fdb78716..d4893cb2 100644 --- a/packages/melos/lib/src/commands/version.dart +++ b/packages/melos/lib/src/commands/version.dart @@ -265,6 +265,11 @@ mixin _VersionMixin on _RunMixin { ); for (final package in dependentPackagesToVersion) { + // If updateDependentsVersions is set to false, we do not perform updates. + if (!updateDependentsVersions) { + continue; + } + final packageHasPendingUpdate = pendingPackageUpdates.any( (packageToVersion) => packageToVersion.package.name == package.name, ); @@ -309,15 +314,10 @@ mixin _VersionMixin on _RunMixin { return; } - final pendingPackageUpdatesCount = updateDependentsVersions - ? pendingPackageUpdates.length - : pendingPackageUpdates - .where((update) => update.reason != PackageUpdateReason.dependency) - .length; logger.log( AnsiStyles.magentaBright( 'The following ' - '${packageNameStyle(pendingPackageUpdatesCount.toString())} ' + '${packageNameStyle(pendingPackageUpdates.length.toString())} ' 'packages will be updated:\n', ), ); @@ -704,7 +704,6 @@ mixin _VersionMixin on _RunMixin { workspace, changelogConfig, pendingPackageUpdates, - updateDependentsVersions: updateDependentsVersions, ); }), ); @@ -714,9 +713,8 @@ mixin _VersionMixin on _RunMixin { Future _writeAggregateChangelog( MelosWorkspace workspace, AggregateChangelogConfig config, - List pendingPackageUpdates, { - required bool updateDependentsVersions, - }) async { + List pendingPackageUpdates, + ) async { final today = DateTime.now(); final dateSlug = [ today.year.toString(), @@ -738,7 +736,6 @@ mixin _VersionMixin on _RunMixin { pendingPackageUpdates, logger, config.path, - updateDependentsVersions: updateDependentsVersions, ); await changelog.write(); diff --git a/packages/melos/lib/src/common/aggregate_changelog.dart b/packages/melos/lib/src/common/aggregate_changelog.dart index 4c973e31..43cb3466 100644 --- a/packages/melos/lib/src/common/aggregate_changelog.dart +++ b/packages/melos/lib/src/common/aggregate_changelog.dart @@ -14,9 +14,8 @@ class AggregateChangelog { this.newEntryTitle, this.pendingPackageUpdates, this.logger, - this.path, { - required this.updateDependentsVersions, - }); + this.path, + ); final MelosWorkspace workspace; final String? description; @@ -24,7 +23,6 @@ class AggregateChangelog { final MelosLogger logger; final List pendingPackageUpdates; final String path; - final bool updateDependentsVersions; String get _changelogFileHeader => ''' # Change Log @@ -46,21 +44,14 @@ ${description?.withoutTrailing('\n') ?? ''} String get markdown { final body = StringBuffer(); - final dependencyOnlyPackages = updateDependentsVersions - ? pendingPackageUpdates - .where((update) => update.reason == PackageUpdateReason.dependency) - : []; + final dependencyOnlyPackages = pendingPackageUpdates + .where((update) => update.reason == PackageUpdateReason.dependency); final graduatedPackages = pendingPackageUpdates .where((update) => update.reason == PackageUpdateReason.graduate); final packagesWithBreakingChanges = pendingPackageUpdates.where((update) => update.hasBreakingChanges); - final packagesWithOtherChanges = pendingPackageUpdates.where((update) { - if (update.reason == PackageUpdateReason.dependency && - !updateDependentsVersions) { - return false; - } - return !update.hasBreakingChanges; - }); + final packagesWithOtherChanges = + pendingPackageUpdates.where((update) => !update.hasBreakingChanges); body.writeln(_changelogFileHeader); body.writeln('## $newEntryTitle');