From ce33534d5213356f1ba42972afeaeeaeafa8ad50 Mon Sep 17 00:00:00 2001 From: Dave Shrestha Date: Wed, 9 Oct 2024 15:18:47 -0700 Subject: [PATCH] Updated multiple examples and validated updates (#47) For examples\gcp-rhel-vm: Had to remove local versions.tf due to conflict of older version with root\version.tf thus just deleted the local versions.tf as it is not needed. After this was done - example VALIDATED. For examples\gcp-windows-vm: Had to remove local versions.tf due to conflict of older version with root\version.tf thus just deleted the local versions.tf as it is not needed. After this was done - example VALIDATED. For examples\gcp-windows-vm-ico-by-densify: variables.tf needed to be modified to set recommendedType = "c4-standard-4"- these changes were also don on readme.md, densify_recommendation.auto.tvars files - VALIDATED. For examples\gcp-linux-vm-ico-by-densify: variables.tf needed to be modified to set recommendedType = "c4-standard-4"- these changes were also don on readme.md, densify_recommendation.auto.tvars files - VALIDATED. --- examples/gcp-linux-vm-ico-by-densify/README.md | 4 ++-- .../densify_recommendations.auto.tfvars | 2 +- examples/gcp-linux-vm-ico-by-densify/variables.tf | 4 ++-- examples/gcp-rhel-vm/versions.tf | 10 ---------- examples/gcp-windows-vm-ico-by-densify/README.md | 4 ++-- .../densify_recommendations.auto.tfvars | 2 +- examples/gcp-windows-vm-ico-by-densify/variables.tf | 4 ++-- examples/gcp-windows-vm/versions.tf | 10 ---------- 8 files changed, 10 insertions(+), 30 deletions(-) delete mode 100644 examples/gcp-rhel-vm/versions.tf delete mode 100644 examples/gcp-windows-vm/versions.tf diff --git a/examples/gcp-linux-vm-ico-by-densify/README.md b/examples/gcp-linux-vm-ico-by-densify/README.md index b43672a..d5b800a 100644 --- a/examples/gcp-linux-vm-ico-by-densify/README.md +++ b/examples/gcp-linux-vm-ico-by-densify/README.md @@ -47,7 +47,7 @@ variable "densify_recommendations" { default = { ico-test = { currentType = "n1-standard-2" - recommendedType = "c3-standard-4" + recommendedType = "c4-standard-4" approvalType = "all" savingsEstimate = "26.6" predictedUptime = "94.32" @@ -62,7 +62,7 @@ variable "densify_fallback"{ type = map(string) default = { currentType = "n1-standard-2" - recommendedType = "c3-standard-4" + recommendedType = "c4-standard-4" approvalType = "all" savingsEstimate = "0" predictedUptime = "0" diff --git a/examples/gcp-linux-vm-ico-by-densify/densify_recommendations.auto.tfvars b/examples/gcp-linux-vm-ico-by-densify/densify_recommendations.auto.tfvars index 751a2bd..144738e 100644 --- a/examples/gcp-linux-vm-ico-by-densify/densify_recommendations.auto.tfvars +++ b/examples/gcp-linux-vm-ico-by-densify/densify_recommendations.auto.tfvars @@ -1,7 +1,7 @@ densify_recommendations = { "ico-test" = { currentType = "n1-standard-2" - recommendedType = "c3-standard-4" + recommendedType = "c4-standard-4" approvalType = "all" predictedUptime = "95.0" recommendationType = "Modernize" diff --git a/examples/gcp-linux-vm-ico-by-densify/variables.tf b/examples/gcp-linux-vm-ico-by-densify/variables.tf index 72fcbad..813dc12 100644 --- a/examples/gcp-linux-vm-ico-by-densify/variables.tf +++ b/examples/gcp-linux-vm-ico-by-densify/variables.tf @@ -15,7 +15,7 @@ variable "densify_recommendations" { default = { ico-test = { currentType = "n1-standard-2" - recommendedType = "c3-standard-4" + recommendedType = "c4-standard-4" approvalType = "all" savingsEstimate = "26.6" predictedUptime = "94.32" @@ -30,7 +30,7 @@ variable "densify_fallback"{ type = map(string) default = { currentType = "n1-standard-2" - recommendedType = "c3-standard-4" + recommendedType = "c4-standard-4" approvalType = "all" savingsEstimate = "0" predictedUptime = "0" diff --git a/examples/gcp-rhel-vm/versions.tf b/examples/gcp-rhel-vm/versions.tf deleted file mode 100644 index f7a50b4..0000000 --- a/examples/gcp-rhel-vm/versions.tf +++ /dev/null @@ -1,10 +0,0 @@ -terraform { - required_version = "~> 1.6" # see https://releases.hashicorp.com/terraform/ - - required_providers { - google = { - source = "hashicorp/google" - version = "~> 5.11" - } - } -} \ No newline at end of file diff --git a/examples/gcp-windows-vm-ico-by-densify/README.md b/examples/gcp-windows-vm-ico-by-densify/README.md index 7a99d54..d588982 100644 --- a/examples/gcp-windows-vm-ico-by-densify/README.md +++ b/examples/gcp-windows-vm-ico-by-densify/README.md @@ -46,7 +46,7 @@ variable "densify_recommendations" { default = { ico-test = { currentType = "n1-standard-2" - recommendedType = "c3-standard-4" + recommendedType = "c4-standard-4" approvalType = "all" savingsEstimate = "26.6" predictedUptime = "94.32" @@ -61,7 +61,7 @@ variable "densify_fallback"{ type = map(string) default = { currentType = "n1-standard-2" - recommendedType = "c3-standard-4" + recommendedType = "c4-standard-4" approvalType = "all" savingsEstimate = "0" predictedUptime = "0" diff --git a/examples/gcp-windows-vm-ico-by-densify/densify_recommendations.auto.tfvars b/examples/gcp-windows-vm-ico-by-densify/densify_recommendations.auto.tfvars index 751a2bd..144738e 100644 --- a/examples/gcp-windows-vm-ico-by-densify/densify_recommendations.auto.tfvars +++ b/examples/gcp-windows-vm-ico-by-densify/densify_recommendations.auto.tfvars @@ -1,7 +1,7 @@ densify_recommendations = { "ico-test" = { currentType = "n1-standard-2" - recommendedType = "c3-standard-4" + recommendedType = "c4-standard-4" approvalType = "all" predictedUptime = "95.0" recommendationType = "Modernize" diff --git a/examples/gcp-windows-vm-ico-by-densify/variables.tf b/examples/gcp-windows-vm-ico-by-densify/variables.tf index 97ef006..81260d6 100644 --- a/examples/gcp-windows-vm-ico-by-densify/variables.tf +++ b/examples/gcp-windows-vm-ico-by-densify/variables.tf @@ -15,7 +15,7 @@ variable "densify_recommendations" { default = { ico-test = { currentType = "n1-standard-2" - recommendedType = "c3-standard-4" + recommendedType = "c4-standard-4" approvalType = "all" savingsEstimate = "26.6" predictedUptime = "94.32" @@ -30,7 +30,7 @@ variable "densify_fallback"{ type = map(string) default = { currentType = "n1-standard-2" - recommendedType = "c3-standard-4" + recommendedType = "c4-standard-4" approvalType = "all" savingsEstimate = "0" predictedUptime = "0" diff --git a/examples/gcp-windows-vm/versions.tf b/examples/gcp-windows-vm/versions.tf deleted file mode 100644 index f7a50b4..0000000 --- a/examples/gcp-windows-vm/versions.tf +++ /dev/null @@ -1,10 +0,0 @@ -terraform { - required_version = "~> 1.6" # see https://releases.hashicorp.com/terraform/ - - required_providers { - google = { - source = "hashicorp/google" - version = "~> 5.11" - } - } -} \ No newline at end of file