Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix startup args passed to the wasm level #4

Open
iansmith opened this issue Dec 13, 2022 · 1 comment
Open

fix startup args passed to the wasm level #4

iansmith opened this issue Dec 13, 2022 · 1 comment

Comments

@iansmith
Copy link
Owner

currently this code inside a warm module will fail:

flag.Parse()

because there are zero command line arguments.

A minimal fix would be to pass the name of the warm module as arg[0] which would allow flag.Parse() to trivially
work. It would be better if command line flags could be passed to the warm module, although this probably means
changes to runner and the docker-compose to allow the passing of args.

@iansmith
Copy link
Owner Author

iansmith commented Jan 2, 2023

This was found in the go-supplied file wasm_exec.js lines 488 to 518 in the 1.19 distribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant