From ddeb5bdd643d8f2b1c222b95dcb4f89e3ccc6958 Mon Sep 17 00:00:00 2001
From: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Date: Wed, 16 Oct 2024 16:12:22 -0700
Subject: [PATCH] Use kw-only args for member access booleans (#17975)

Gets hard to know what's what at call site
---
 mypy/checker.py      |  8 ++++----
 mypy/checkexpr.py    | 32 ++++++++++++++++----------------
 mypy/checkmember.py  | 35 ++++++++++++++++++-----------------
 mypy/checkpattern.py | 16 ++++++++--------
 4 files changed, 46 insertions(+), 45 deletions(-)

diff --git a/mypy/checker.py b/mypy/checker.py
index ca35144456fe..c646ebf3736b 100644
--- a/mypy/checker.py
+++ b/mypy/checker.py
@@ -7570,10 +7570,10 @@ def has_valid_attribute(self, typ: Type, name: str) -> bool:
                 name,
                 typ,
                 TempNode(AnyType(TypeOfAny.special_form)),
-                False,
-                False,
-                False,
-                self.msg,
+                is_lvalue=False,
+                is_super=False,
+                is_operator=False,
+                msg=self.msg,
                 original_type=typ,
                 chk=self,
                 # This is not a real attribute lookup so don't mess with deferring nodes.
diff --git a/mypy/checkexpr.py b/mypy/checkexpr.py
index 0754b1db7141..8d1833a772e2 100644
--- a/mypy/checkexpr.py
+++ b/mypy/checkexpr.py
@@ -1504,10 +1504,10 @@ def check_union_call_expr(self, e: CallExpr, object_type: UnionType, member: str
                     member,
                     typ,
                     e,
-                    False,
-                    False,
-                    False,
-                    self.msg,
+                    is_lvalue=False,
+                    is_super=False,
+                    is_operator=False,
+                    msg=self.msg,
                     original_type=object_type,
                     chk=self.chk,
                     in_literal_context=self.is_literal_context(),
@@ -3302,10 +3302,10 @@ def analyze_ordinary_member_access(self, e: MemberExpr, is_lvalue: bool) -> Type
                 e.name,
                 original_type,
                 e,
-                is_lvalue,
-                False,
-                False,
-                self.msg,
+                is_lvalue=is_lvalue,
+                is_super=False,
+                is_operator=False,
+                msg=self.msg,
                 original_type=original_type,
                 chk=self.chk,
                 in_literal_context=self.is_literal_context(),
@@ -3326,10 +3326,10 @@ def analyze_external_member_access(
             member,
             base_type,
             context,
-            False,
-            False,
-            False,
-            self.msg,
+            is_lvalue=False,
+            is_super=False,
+            is_operator=False,
+            msg=self.msg,
             original_type=base_type,
             chk=self.chk,
             in_literal_context=self.is_literal_context(),
@@ -3809,10 +3809,10 @@ def check_method_call_by_name(
             method,
             base_type,
             context,
-            False,
-            False,
-            True,
-            self.msg,
+            is_lvalue=False,
+            is_super=False,
+            is_operator=True,
+            msg=self.msg,
             original_type=original_type,
             chk=self.chk,
             in_literal_context=self.is_literal_context(),
diff --git a/mypy/checkmember.py b/mypy/checkmember.py
index 4448072d52c3..e6f7570c3df2 100644
--- a/mypy/checkmember.py
+++ b/mypy/checkmember.py
@@ -87,6 +87,7 @@ class MemberContext:
 
     def __init__(
         self,
+        *,
         is_lvalue: bool,
         is_super: bool,
         is_operator: bool,
@@ -126,16 +127,16 @@ def copy_modified(
         original_type: Type | None = None,
     ) -> MemberContext:
         mx = MemberContext(
-            self.is_lvalue,
-            self.is_super,
-            self.is_operator,
-            self.original_type,
-            self.context,
-            self.msg,
-            self.chk,
-            self.self_type,
-            self.module_symbol_table,
-            self.no_deferral,
+            is_lvalue=self.is_lvalue,
+            is_super=self.is_super,
+            is_operator=self.is_operator,
+            original_type=self.original_type,
+            context=self.context,
+            msg=self.msg,
+            chk=self.chk,
+            self_type=self.self_type,
+            module_symbol_table=self.module_symbol_table,
+            no_deferral=self.no_deferral,
         )
         if messages is not None:
             mx.msg = messages
@@ -152,11 +153,11 @@ def analyze_member_access(
     name: str,
     typ: Type,
     context: Context,
+    *,
     is_lvalue: bool,
     is_super: bool,
     is_operator: bool,
     msg: MessageBuilder,
-    *,
     original_type: Type,
     chk: mypy.checker.TypeChecker,
     override_info: TypeInfo | None = None,
@@ -190,12 +191,12 @@ def analyze_member_access(
     are not available via the type object directly)
     """
     mx = MemberContext(
-        is_lvalue,
-        is_super,
-        is_operator,
-        original_type,
-        context,
-        msg,
+        is_lvalue=is_lvalue,
+        is_super=is_super,
+        is_operator=is_operator,
+        original_type=original_type,
+        context=context,
+        msg=msg,
         chk=chk,
         self_type=self_type,
         module_symbol_table=module_symbol_table,
diff --git a/mypy/checkpattern.py b/mypy/checkpattern.py
index fa23dfb5f453..6b4fa35f9c49 100644
--- a/mypy/checkpattern.py
+++ b/mypy/checkpattern.py
@@ -594,10 +594,10 @@ def visit_class_pattern(self, o: ClassPattern) -> PatternType:
                         "__match_args__",
                         typ,
                         o,
-                        False,
-                        False,
-                        False,
-                        self.msg,
+                        is_lvalue=False,
+                        is_super=False,
+                        is_operator=False,
+                        msg=self.msg,
                         original_type=typ,
                         chk=self.chk,
                     )
@@ -660,10 +660,10 @@ def visit_class_pattern(self, o: ClassPattern) -> PatternType:
                         keyword,
                         narrowed_type,
                         pattern,
-                        False,
-                        False,
-                        False,
-                        self.msg,
+                        is_lvalue=False,
+                        is_super=False,
+                        is_operator=False,
+                        msg=self.msg,
                         original_type=new_type,
                         chk=self.chk,
                     )