Redundant packet batching logic in usbd_control.c #1794
rianhunter
started this conversation in
General
Replies: 1 comment
-
have you run the stack with/without the changes and observe its changed behavior ? If yes, then please attach the txt containing logs file in both cases with highlight/note where the changes code apply/affect the behavior. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I noticed that calling
_data_stage_xact()
with a buffer larger thanCFG_TUD_ENDPOINT0_SIZE
will cause a series of calls tousbd_edpt_xfer()
until the entire buffer is transferred.Batching at this layer does not seem necessary since
usbd_edpt_xfer()
will handle large buffers. It seems you can change:into
and everything will continue to work, the dcd layer will be responsible for splitting up the buffer into sequential packets.
I can provide a patch for that if you agree with my logic. Thank you
Beta Was this translation helpful? Give feedback.
All reactions