feat(provider): Support worker filter on dynamic host catalogs #626
+302
−161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoghx
force-pushed
the
hugo-dhc-workerfilter
branch
from
00b11db
to
2a1ba22
Compare
This comment was marked as resolved.
This comment was marked as resolved.
louisruch
reviewed
Oct 9, 2024
hugoghx
force-pushed
the
hugo-dhc-workerfilter
branch
from
acd3e53
to
9d5d0ec
Compare
louisruch
reviewed
Oct 10, 2024
| @@ -94,6 +94,7 @@ resource "boundary_host_catalog_plugin" "azure_example" { | |||
| - `plugin_name` (String) The name of the plugin that should back the resource. This or plugin_id must be defined. | |||
| - `secrets_hmac` (String) The HMAC'd secrets value returned from the server. | |||
| - `secrets_json` (String, Sensitive) The secrets for the host catalog. Either values encoded with the "jsonencode" function, pre-escaped JSON string, or a file:// or env:// path. Set to a string "null" to clear any existing values. NOTE: Unlike "attributes_json", removing this block will NOT clear secrets from the host catalog; this allows injecting secrets for one call, then removing them for storage. | |||
| - `worker_filter` (String) HCP Only. A filter used to control which PKI workers can handle dynamic host catalog requests. | |||
There was a problem hiding this comment.
Interesting I wonder if we need to update our other usage of HCP Only - this is a relic of before we had self hosted. Perhaps we should align this with Enterprise-only as we did in Boundary. But perhpas worth starting a thread and taggin Anando from product on his thoughts
There was a problem hiding this comment.
Yeah, I really only followed our current convention in these docs, but this is technically incorrect.
I suppose we could update it everywhere to say HCP and Boundary Enterprise only or something like this. @anando-chatterjee WDYT?
There was a problem hiding this comment.
There was a problem hiding this comment.
hugoghx
force-pushed
the
hugo-dhc-workerfilter
branch
2 times, most recently
from
fc7f471
to
4efc373
Compare
hugoghx
force-pushed
the
hugo-dhc-workerfilter
branch
from
4efc373
to
dd817de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.